Skip to content

Commit b194728

Browse files
authored
feat(tracks): enable remove track again (#168)
1 parent b166816 commit b194728

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

pkg/webrtctransport.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -244,13 +244,12 @@ func (p *WebRTCTransport) NewSender(intrack *webrtc.Track) (Sender, error) {
244244
// Create webrtc sender for the peer we are sending track to
245245
sender := NewWebRTCSender(p.ctx, outtrack, s)
246246

247-
// TODO: remove once resolved https://github.com/pion/webrtc/issues/1343
248-
// sender.OnClose(func() {
249-
// err = p.pc.RemoveTrack(s)
250-
// if err != nil {
251-
// log.Errorf("Error closing sender: %s", err)
252-
// }
253-
// })
247+
sender.OnClose(func() {
248+
err = p.pc.RemoveTrack(s)
249+
if err != nil {
250+
log.Errorf("Error closing sender: %s", err)
251+
}
252+
})
254253

255254
return sender, nil
256255
}

0 commit comments

Comments
 (0)