Skip to content

Commit 5bef559

Browse files
committed
test(e2e): move address verification into existing single CP test
Fold the ProxmoxMachine status addresses check into the existing "Creating a single control-plane cluster" test instead of provisioning a separate cluster just for this assertion. This avoids an extra 20-30 min cluster bring-up in the e2e pipeline. The verification now runs right after ApplyClusterTemplateAndWait and before scaling, reusing the already-provisioned cluster. https://claude.ai/code/session_01PEJQFPT9TvRGqFYJ1t3U1R
1 parent 96f2a50 commit 5bef559

1 file changed

Lines changed: 3 additions & 27 deletions

File tree

test/e2e/capmox_test.go

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,9 @@ var _ = Describe("Workload cluster creation", func() {
102102
WaitForMachineDeployments: e2eConfig.GetIntervals(specName, "wait-worker-nodes"),
103103
}, result)
104104

105+
By("Verifying ProxmoxMachine status addresses are populated")
106+
verifyProxmoxMachineAddresses(ctx, bootstrapClusterProxy, namespace.Name, clusterName)
107+
105108
By("Scaling worker node to 3")
106109
framework.ScaleAndWaitMachineDeployment(ctx, framework.ScaleAndWaitMachineDeploymentInput{
107110
ClusterProxy: bootstrapClusterProxy,
@@ -137,33 +140,6 @@ var _ = Describe("Workload cluster creation", func() {
137140
})
138141
})
139142

140-
Context("[Generic] Creating a cluster and verifying ProxmoxMachine status addresses", func() {
141-
It("Should have populated addresses on ProxmoxMachine status", func() {
142-
By("Creating a cluster with 1 control-plane and 1 worker node")
143-
clusterctl.ApplyClusterTemplateAndWait(ctx, clusterctl.ApplyClusterTemplateAndWaitInput{
144-
ClusterProxy: bootstrapClusterProxy,
145-
ConfigCluster: clusterctl.ConfigClusterInput{
146-
LogFolder: clusterctlLogFolder,
147-
ClusterctlConfigPath: clusterctlConfigPath,
148-
KubeconfigPath: bootstrapClusterProxy.GetKubeconfigPath(),
149-
InfrastructureProvider: clusterctl.DefaultInfrastructureProvider,
150-
Flavor: clusterctl.DefaultFlavor,
151-
Namespace: namespace.Name,
152-
ClusterName: clusterName,
153-
KubernetesVersion: e2eConfig.MustGetVariable(KubernetesVersion),
154-
ControlPlaneMachineCount: pointer.Int64Ptr(1),
155-
WorkerMachineCount: pointer.Int64Ptr(1),
156-
},
157-
WaitForClusterIntervals: e2eConfig.GetIntervals(specName, "wait-cluster"),
158-
WaitForControlPlaneIntervals: e2eConfig.GetIntervals(specName, "wait-control-plane"),
159-
WaitForMachineDeployments: e2eConfig.GetIntervals(specName, "wait-worker-nodes"),
160-
}, result)
161-
162-
By("Verifying ProxmoxMachine status addresses are populated")
163-
verifyProxmoxMachineAddresses(ctx, bootstrapClusterProxy, namespace.Name, clusterName)
164-
})
165-
})
166-
167143
Context("[Flatcar] Creating a highly available control-plane cluster with flatcar", func() {
168144
It("Should create a HA cluster with flatcar", func() {
169145
By("Creating a flatcar high available cluster")

0 commit comments

Comments
 (0)