feat: cross-check capmox release files in verify-versions

Catch drift between the four files release.sh updates together:

- clusterctl-settings.json (nextVersion) and sonar-project.properties
  (projectVersion) must match after stripping the v-prefix
- clusterctl nextVersion's major.minor must be listed in metadata.yaml
  releaseSeries
- the capmox sentinel in test/e2e/config/proxmox-*.yaml must equal
  v{major}.{minor}.99 for that same major.minor

Pre-release suffixes (-rc.0, -beta.1, ...) are stripped from clusterctl
nextVersion before checking major.minor.

Co-authored-by: Claude <noreply@anthropic.com>

Author: wikkyk

hack/spec/verify_versions_spec.sh

@@ -80,4 +80,34 @@ Describe 'verify-versions.sh'
     The status should be failure
     The output should include 'k8s.io/code-generator version mismatch'
   End
+
+  It 'detects capmox clusterctl/sonar drift'
+    sonar_set_version '0.8.2' >/dev/null
+    When run script ../verify-versions.sh
+    The status should be failure
+    The output should include 'capmox version mismatch'
+  End
+
+  It 'detects capmox major.minor not listed in metadata.yaml'
+    clusterctl_set_version 'v0.99.0' >/dev/null
+    sonar_set_version '0.99.0' >/dev/null
+    e2econfig_set_capmox 'v0.99.99' >/dev/null
+    When run script ../verify-versions.sh
+    The status should be failure
+    The output should include 'v0.99 is not listed in metadata.yaml'
+  End
+
+  It 'detects capmox e2e sentinel mismatch'
+    e2econfig_set_capmox 'v0.7.99' >/dev/null
+    When run script ../verify-versions.sh
+    The status should be failure
+    The output should include 'capmox e2e sentinel mismatch'
+  End
+
+  It 'accepts a pre-release clusterctl version whose core is in metadata'
+    clusterctl_set_version 'v0.8.2-rc.0' >/dev/null
+    sonar_set_version '0.8.2-rc.0' >/dev/null
+    When run script ../verify-versions.sh
+    The status should be success
+  End
 End

hack/verify-versions.sh

@@ -145,6 +145,42 @@ if [[ -n "${CAPI_REQUIRE}" && -n "${E2E_CAPI_VER}" ]]; then
     fi
 fi
 
+# ---- capmox release version consistency ----
+# clusterctl-settings.json (nextVersion), sonar-project.properties
+# (projectVersion), metadata.yaml (releaseSeries), and the e2e sentinel
+# must all agree on the upcoming release's major.minor. release.sh keeps
+# them in sync; this check catches drift.
+
+CAPMOX_NEXT=$(clusterctl_get_version)
+CAPMOX_SONAR=$(sonar_get_version)
+CAPMOX_SENTINEL=$(e2econfig_get_capmox)
+
+if [[ -n "${CAPMOX_NEXT}" && -n "${CAPMOX_SONAR}" ]]; then
+    # clusterctl carries the v-prefix, sonar does not — strip before compare.
+    if [[ "$(strip_v_prefix "${CAPMOX_NEXT}")" != "${CAPMOX_SONAR}" ]]; then
+        fail "capmox version mismatch: clusterctl-settings.json has '${CAPMOX_NEXT}', sonar-project.properties has '${CAPMOX_SONAR}'"
+    fi
+fi
+
+if [[ -n "${CAPMOX_NEXT}" ]]; then
+    # Strip any pre-release suffix (-rc.0, -beta.1, ...) to compare major.minor.
+    CAPMOX_CORE="${CAPMOX_NEXT%%-*}"
+    split_version "${CAPMOX_CORE}"
+    CAPMOX_MAJOR="${MAJOR}"
+    CAPMOX_MINOR="${MINOR}"
+
+    if ! metadata_has_release "${CAPMOX_MAJOR}" "${CAPMOX_MINOR}"; then
+        fail "capmox v${CAPMOX_MAJOR}.${CAPMOX_MINOR} is not listed in metadata.yaml"
+    fi
+
+    if [[ -n "${CAPMOX_SENTINEL}" ]]; then
+        EXPECTED_SENTINEL="v${CAPMOX_MAJOR}.${CAPMOX_MINOR}.99"
+        if versions_differ "${CAPMOX_SENTINEL}" "${EXPECTED_SENTINEL}"; then
+            fail "capmox e2e sentinel mismatch: clusterctl-settings.json is '${CAPMOX_NEXT}', expected sentinel '${EXPECTED_SENTINEL}' but e2e config has '${CAPMOX_SENTINEL}'"
+        fi
+    fi
+fi
+
 # ---- Report results ----
 
 if [[ ${#ERRORS[@]} -gt 0 ]]; then