Deprecate passing ds arg to every checker

ocefpaf · web-flow · commit 0203e8326b1a · 2026-04-08T16:37:42.000-04:00
diff --git a/compliance_checker/base.py b/compliance_checker/base.py
@@ -142,6 +142,9 @@ class BaseCheck:
 
     supported_ds = []
 
+    @deprecated(
+        "Passing the dataset to every single check is deprecated. The future version will take the ds only in the test constructor.",
+    )
     def setup(self, ds):
         """
         Common setup method for a Checker.
diff --git a/pyproject.toml b/pyproject.toml
@@ -145,4 +145,5 @@ ini_options.filterwarnings = [
   "ignore:unclosed database in",                                           # Not sure what is causing this one, only happens in Python 3.13.
   "ignore:unclosed file",                                                  # Should make Windows + Python 3.10 and 3.11 pass, we should check when this warning was triggered first.
   "ignore:The ioos_sos checker is deprecated and will be removed",
+  "ignore:Passing the dataset to every single check is deprecated."
 ]

Original file line number	Diff line number	Diff line change
`@@ -145,4 +145,5 @@ ini_options.filterwarnings = [`
`145`	`145`	`"ignore:unclosed database in", # Not sure what is causing this one, only happens in Python 3.13.`
`146`	`146`	`"ignore:unclosed file", # Should make Windows + Python 3.10 and 3.11 pass, we should check when this warning was triggered first.`
`147`	`147`	`"ignore:The ioos_sos checker is deprecated and will be removed",`
	`148`	`+ "ignore:Passing the dataset to every single check is deprecated."`
`148`	`149`	`]`