Skip to content

refactor: electron libs to typescript #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jeeanribeiro
Copy link
Contributor

@jeeanribeiro jeeanribeiro commented Oct 4, 2022

Summary

We need to improve our code quality to have better maintainability and be easier to port our application to Tauri if we want to

Changelog

- Refactors electron/lib folder to TypeScript
- Applies code conventions

Relevant Issues

closes #2081

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro self-assigned this Oct 4, 2022
@jeeanribeiro jeeanribeiro linked an issue Oct 4, 2022 that may be closed by this pull request
3 tasks
@jeeanribeiro jeeanribeiro force-pushed the refactor/electron-lib-ts branch 9 times, most recently from d57927e to 5338db4 Compare October 10, 2022 15:24
@jeeanribeiro jeeanribeiro force-pushed the refactor/electron-lib-ts branch 6 times, most recently from 0d08512 to 16a9aef Compare October 17, 2022 19:55
@jeeanribeiro jeeanribeiro force-pushed the refactor/electron-lib-ts branch 2 times, most recently from fef6229 to 1b25b35 Compare November 5, 2022 21:54
@jeeanribeiro jeeanribeiro force-pushed the refactor/electron-lib-ts branch from 1b25b35 to 37429a3 Compare November 7, 2022 13:56
@begonaalvarezd begonaalvarezd deleted the refactor/electron-lib-ts branch August 23, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Refactor Electron libraries from Javascript to Typescript
1 participant