Merge pull request #112 from iotexproject/chore/update-smoketests

fix(smokeTests): improve success detection in smoke test script

Author: nicky-ru

scripts/smokeTests.sh

@@ -97,7 +97,14 @@ while true; do
         exit 1
     fi
 
-    # Check if process is still alive
+    # Check for success FIRST (before checking if process died)
+    if grep -q ".*REST API bound to 0.0.0.0.*" "$OUTFILE"; then
+        >&2 echo "SUCCESS: Direct Client API is ready! Proceeding..."
+        SUCCESS=true
+        break
+    fi
+
+    # Only check if process is still alive if we haven't found success yet
     if ! kill -0 $APP_PID 2>/dev/null; then
         >&2 echo "ERROR: Application process died unexpectedly after $((TIMER / 10)) seconds"
         >&2 echo "Dumping full log output for debugging:"
@@ -109,11 +116,6 @@ while true; do
         exit 1
     fi
 
-    if grep -q ".*REST API bound to 0.0.0.0.*" "$OUTFILE"; then
-        >&2 echo "SUCCESS: Direct Client API is ready! Proceeding..."
-        break
-    fi
-
     # Log progress every 10 seconds (20 iterations)
     if (( TIMER % 100 == 0 && TIMER > 0 )); then
         >&2 echo "Still waiting for application to start... ($((TIMER / 10)) seconds elapsed)"
@@ -128,28 +130,21 @@ done
 if kill -0 $APP_PID 2>/dev/null; then
     kill $APP_PID
     wait $APP_PID 2>/dev/null || true
-    RESULT=$?
 else
     echo "Process $APP_PID already terminated"
-    RESULT=0  # Consider successful if process already exited
 fi
 
 # Output logs
 echo "----- OUTPUT START -----"
 cat "$OUTFILE"
 echo "----- OUTPUT END -----"
 
-# Check the application exit code
-if [[ $RESULT -ne 0 ]]; then
-    echo "Error: 'pnpm start' command exited with an error (code: $RESULT)"
-    exit 1
+# If we saw the REST API bind message, consider smoke test successful
+if [[ "${SUCCESS:-false}" == "true" ]]; then
+    echo "Smoke Test completed successfully - REST API bound successfully."
+    exit 0
 fi
 
-# Final validation
-if grep -q "Server closed successfully" "$OUTFILE"; then
-    echo "Smoke Test completed successfully."
-else
-    echo "Error: The output does not contain the expected termination message but was completed."
-    echo "Smoke Test completed without completion message."
-    # Exit gracefully
-fi
+# If we got here without SUCCESS flag, something went wrong
+echo "Error: Smoke test did not complete successfully."
+exit 1