Updated pylint to 2.13.0 to address security issue (#159)

* Updated pylint to 2.13.0 to address security issue

* Updated linting rules as well as changed a couple linting errors to better match the defaults from PyLint

* Updated version and changelog

Co-authored-by: Brad Porter <[email protected]>

Author: lordkyzr

.pylintrc

@@ -1,2 +1,2 @@
 [MASTER]
-disable=useless-object-inheritance
+disable=useless-object-inheritance,consider-using-f-string

CHANGES.rst

@@ -1,6 +1,10 @@
 CHANGELOG for LaunchKey Python SDK
 ==================================
 
+4.0.1
+-----
+* Updated dependencies and fixed security issue for PyLint in dev dependencies
+
 4.0.0
 -----
 

Pipfile

@@ -14,7 +14,7 @@ mock = ">= 2.0.0, < 3.0.0"
 ddt = ">= 1.1.1, < 2.0.0"
 # Tools for static analysis
 flake8 = "~=3.8.3"
-pylint = "~=2.7.0"
+pylint = "~=2.13.0"
 coverage = "~=4.5.2"
 # Tools for multi-environment testing before sending to CI
 tox = "~=3.8.0"

Pipfile.lock

@@ -1,5 +1,5 @@
 """LaunchKey Service SDK module"""
-SDK_VERSION = '4.0.0'
+SDK_VERSION = '4.0.1'
 LAUNCHKEY_PRODUCTION = "https://api.launchkey.com"
 VALID_JWT_ISSUER_LIST = ["svc", "dir", "org"]
 JOSE_SUPPORTED_JWE_ALGS = ['RSA-OAEP']

launchkey/__init__.py

@@ -264,6 +264,7 @@ def update_service(self, service_id, name=False, description=False,
         self._transport.patch(self.__service_base_path, self._subject,
                               **kwargs)
 
+    # pylint: disable = duplicate-code
     @api_call
     def add_service_public_key(self, service_id, public_key, expires=None,
                                active=None, key_type=None):
@@ -523,7 +524,7 @@ def __geofence_to_geo_circle(geofence):
 
     @staticmethod
     def __generate_fence_objects_from_policy(policy):
-        fences = list()
+        fences = []
         for fence in policy["fences"]:
             if fence["type"] == "GEO_CIRCLE":
                 fences.append(

launchkey/clients/base.py

@@ -135,6 +135,7 @@ def get_directory_public_keys(self, directory_id):
                                      self._subject,
                                      directory_id=str(directory_id)).data]
 
+    # pylint: disable = duplicate-code
     @api_call
     def add_directory_public_key(self, directory_id, public_key, expires=None,
                                  active=None, key_type=None):

launchkey/clients/organization.py

@@ -486,7 +486,7 @@ def decrypt_response(self, response):
         :return: Decrypted string
         """
         package = JWEnc().unpack(response)
-        keys = list()
+        keys = []
         if 'kid' in package.headers:
             for key in self.issuer_private_keys:
                 if key.kid == package.headers['kid']: