review changes

Author: gammazero

bitswap/client/internal/messagequeue/messagequeue.go

@@ -333,14 +333,6 @@ func newMessageQueue(
 	}
 }
 
-func (mq *MessageQueue) Sync() <-chan struct{} {
-	done := make(chan struct{})
-	mq.requests.In() <- func() {
-		close(done)
-	}
-	return done
-}
-
 // Add want-haves that are part of a broadcast to all connected peers
 func (mq *MessageQueue) AddBroadcastWantHaves(wantHaves []cid.Cid) {
 	if len(wantHaves) == 0 {

bitswap/client/internal/peermanager/peermanager.go

@@ -95,16 +95,18 @@ func (pm *PeerManager) Connected(p peer.ID) {
 // Disconnected is called to remove a peer from the pool.
 func (pm *PeerManager) Disconnected(p peer.ID) {
 	pm.pqLk.Lock()
-	defer pm.pqLk.Unlock()
 
 	pq, ok := pm.peerQueues[p]
 	if !ok {
+		pm.pqLk.Unlock()
 		return
 	}
 	// Clean up the peer
 	delete(pm.peerQueues, p)
 	pm.pwm.removePeer(p)
 
+	pm.pqLk.Unlock()
+
 	// Inform the sessions that the peer has disconnected
 	pm.signalAvailability(p, false)