test: fix flaky repo verify

lidel · lidel · commit 3aed24ae82b2 · 2025-03-05T21:04:24.000+01:00
it seems verify not always notices file was broken, this fix performs
explicit flush and assumes CI uses filesystem with lazy flush or some
other unknown behavior
diff --git a/test/sharness/t0086-repo-verify.sh b/test/sharness/t0086-repo-verify.sh
@@ -28,15 +28,17 @@ check_random_corruption() {
 
   test_expect_success "back up file and overwrite it" '
     cp "$to_break" backup_file &&
-    echo "this is super broken" > "$to_break"
+    echo "this is super broken" > "$to_break" &&
+    sync "$to_break"
   '
 
   test_expect_success "repo verify detects failure" '
     test_expect_code 1 ipfs repo verify
   '
 
-  test_expect_success "replace the object" '
-    cp backup_file "$to_break"
+  test_expect_success "restore broken object" '
+    cp backup_file "$to_break" &&
+    sync "$to_break"
   '
 
   test_expect_success "ipfs repo verify passes just fine now" '

Original file line number	Diff line number	Diff line change
`@@ -28,15 +28,17 @@ check_random_corruption() {`
`28`	`28`
`29`	`29`	`test_expect_success "back up file and overwrite it" '`
`30`	`30`	`cp "$to_break" backup_file &&`
`31`		`- echo "this is super broken" > "$to_break"`
	`31`	`+ echo "this is super broken" > "$to_break" &&`
	`32`	`+ sync "$to_break"`
`32`	`33`	`'`
`33`	`34`
`34`	`35`	`test_expect_success "repo verify detects failure" '`
`35`	`36`	`test_expect_code 1 ipfs repo verify`
`36`	`37`	`'`
`37`	`38`
`38`		`- test_expect_success "replace the object" '`
`39`		`- cp backup_file "$to_break"`
	`39`	`+ test_expect_success "restore broken object" '`
	`40`	`+ cp backup_file "$to_break" &&`
	`41`	`+ sync "$to_break"`
`40`	`42`	`'`
`41`	`43`
`42`	`44`	`test_expect_success "ipfs repo verify passes just fine now" '`