refactor(runtime): distinguish unfulfilled futures from cancellation#47
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change separates a pending future that outlives its owner scope from cancellation.
When a scope closes with futures it still owns unresolved, those futures now settle as unfulfilled rather than canceled. The closed-owner case is not a request to cancel the observer; it means the result slot reached its lifetime boundary before any producer fulfilled it.
The host boundary keeps that distinction visible as
UnfulfilledError, so callers do not receive a cancellation error for a future that was never fulfilled. The related docs wording is adjusted to describe that boundary consistently.