Update shellcheck directives to improve configuration sourcing in automation scripts

Author: gmartinez-dbai

automation/cleanup_reports.sh

@@ -31,7 +31,8 @@ COMPRESS_OLD="true"
 # Load configuration
 CONFIG_FILE="$SCRIPT_DIR/pgtools.conf"
 if [[ -f "$CONFIG_FILE" ]]; then
-    # shellcheck source=automation/pgtools.conf
+    # shellcheck disable=SC1091
+    # shellcheck source=pgtools.conf
     source "$CONFIG_FILE"
     KEEP_DAYS="${PGTOOLS_KEEP_REPORTS_DAYS:-$KEEP_DAYS}"
 fi

automation/export_metrics.sh

@@ -67,7 +67,8 @@ EOF
 # Load configuration
 CONFIG_FILE="$SCRIPT_DIR/pgtools.conf"
 if [[ -f "$CONFIG_FILE" ]]; then
-    # shellcheck source=automation/pgtools.conf
+    # shellcheck disable=SC1091
+    # shellcheck source=pgtools.conf
     source "$CONFIG_FILE"
 fi
 

automation/pgtools_health_check.sh

@@ -152,7 +152,8 @@ mkdir -p "$OUTPUT_DIR"
 # Load configuration if available
 if [[ -f "$CONFIG_FILE" ]]; then
     log "Loading configuration from $CONFIG_FILE"
-    # shellcheck source=automation/pgtools.conf
+    # shellcheck disable=SC1091
+    # shellcheck source=pgtools.conf
     source "$CONFIG_FILE"
 else
     warn "Configuration file not found: $CONFIG_FILE"
@@ -243,12 +244,20 @@ run_health_checks() {
         scripts_to_run="ESSENTIAL_SCRIPTS"
     else
         log "Running full health check"
-        scripts_to_run="FULL_SCRIPTS"
-        
-        # Add essential scripts to full run
+        # shellcheck disable=SC2034 # referenced through nameref
+        local -A combined_scripts=()
+        local key
+
+        for key in "${!FULL_SCRIPTS[@]}"; do
+            combined_scripts["$key"]="${FULL_SCRIPTS[$key]}"
+        done
+        # shellcheck disable=SC2034
         for key in "${!ESSENTIAL_SCRIPTS[@]}"; do
-            FULL_SCRIPTS["$key"]="${ESSENTIAL_SCRIPTS[$key]}"
+            combined_scripts["$key"]="${ESSENTIAL_SCRIPTS[$key]}"
         done
+        # shellcheck enable=SC2034
+
+        scripts_to_run="combined_scripts"
     fi
 
     local -n scripts_ref=$scripts_to_run

automation/pgtools_scheduler.sh

@@ -61,13 +61,15 @@ EOF
 # Load configuration
 CONFIG_FILE="$SCRIPT_DIR/pgtools.conf"
 if [[ -f "$CONFIG_FILE" ]]; then
-    # shellcheck source=automation/pgtools.conf
+    # shellcheck disable=SC1091
+    # shellcheck source=pgtools.conf
     source "$CONFIG_FILE"
 else
     warn "Configuration file not found: $CONFIG_FILE"
     warn "Using defaults and example configuration"
     if [[ -f "$SCRIPT_DIR/pgtools.conf.example" ]]; then
-        # shellcheck source=automation/pgtools.conf.example
+        # shellcheck disable=SC1091
+        # shellcheck source=pgtools.conf.example
         source "$SCRIPT_DIR/pgtools.conf.example"
     fi
 fi

automation/run_hot_update_report.sh

@@ -42,7 +42,8 @@ EOF
 }
 
 if [[ -f "$CONFIG_FILE" ]]; then
-    # shellcheck source=automation/pgtools.conf
+    # shellcheck disable=SC1091
+    # shellcheck source=pgtools.conf
     source "$CONFIG_FILE"
 fi
 

automation/run_security_audit.sh

@@ -61,7 +61,8 @@ EOF
 # Load configuration
 CONFIG_FILE="$SCRIPT_DIR/pgtools.conf"
 if [[ -f "$CONFIG_FILE" ]]; then
-    # shellcheck source=automation/pgtools.conf
+    # shellcheck disable=SC1091
+    # shellcheck source=pgtools.conf
     source "$CONFIG_FILE"
 fi
 

automation/test_pgtools.sh

@@ -106,7 +106,8 @@ fi
 # Load configuration
 CONFIG_FILE="$SCRIPT_DIR/pgtools.conf"
 if [[ -f "$CONFIG_FILE" ]]; then
-    # shellcheck source=automation/pgtools.conf
+    # shellcheck disable=SC1091
+    # shellcheck source=pgtools.conf
     source "$CONFIG_FILE"
 fi