Comment

AaronStGeorge · AaronStGeorge · commit c552088af0d8 · 2025-11-19T23:43:26.000Z
diff --git a/plugins/hipdnn-plugin/CMakeLists.txt b/plugins/hipdnn-plugin/CMakeLists.txt
@@ -41,7 +41,7 @@ list(PREPEND FUSILLI_PLUGIN_WARNING_COMPILE_OPTIONS
     -Winit-self                              # Warn about variables initialized with itself
     -Wunreachable-code                       # Warn about unreachable code
     -Wno-error=unused-command-line-argument  # Disable error for unused command line arguments
-    -Wno-gnu-statement-expression            # TODO
+    -Wno-gnu-statement-expression            # Disable gnu error for statement expression, this will need to change on Windows.
     -Wswitch-default                         # Warn if a switch statement does not have a default case
 )
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ list(PREPEND FUSILLI_PLUGIN_WARNING_COMPILE_OPTIONS`
`41`	`41`	`-Winit-self # Warn about variables initialized with itself`
`42`	`42`	`-Wunreachable-code # Warn about unreachable code`
`43`	`43`	`-Wno-error=unused-command-line-argument # Disable error for unused command line arguments`
`44`		`- -Wno-gnu-statement-expression # TODO`
	`44`	`+ -Wno-gnu-statement-expression # Disable gnu error for statement expression, this will need to change on Windows.`
`45`	`45`	`-Wswitch-default # Warn if a switch statement does not have a default case`
`46`	`46`	`)`
`47`	`47`