Skip to content

generate.py bakes current username into expected output blob URLs #166

Description

@rkayaith

save_expected_output in torch_ops/generate.py uses pwd.getpwuid(os.getuid()).pw_name to namespace expected result blobs under the current Unix user's name:

https://github.com/iree-org/iree-test-suites/blob/9f54d79/torch_ops/generate.py#L98-L100

This means re-running a test generator (e.g. boo_tests.py) overwrites run_module_io.json with new blob URLs pointing to the current user's namespace, even if the expected results are already uploaded under a different user. The existing blobs can't be reused without manually reverting the URL change.

This could be addressed by using a fixed namespace (e.g. based on the test name/content hash) instead of the username, or by having the generator check for existing blobs before overwriting URLs.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions