Skip to content

[Feature request] wait_pdp_discovery should use the topology to wait for participant discovery. #8

@EduPonz

Description

@EduPonz

I all!

We have been using this tool to test the performance of Fast-RTPS for some time. Recently, Fast-RTPS has added a new feature which is a participant white-list, meaning that users can use the XML to set, for each participant, a list of participants that are "allowed" to be discovered. We believe that this feature really much applies to the benchmark case where the topology is known beforehand.

However, we have encountered a problem when using this participant white-listing, which is that we hit the assertion in performance_test::System::wait_pdp_discovery()

// check if maximum discovery time exceeded
auto t = std::chrono::high_resolution_clock::now();
auto duration =
        std::chrono::duration_cast<std::chrono::milliseconds>(t - pdp_start_time - max_pdp_time).count();
if (duration > 0){
        assert(0 && "[discovery] PDP took more than maximum discovery time");
}

The problem is that with the white-list, the nodes do not discover all the other nodes, but only they ones the are interested in. We have tackled this issue by avoiding to wait for participant discovery using PR #7, but we believe that a better approach would be to refactor performance_test::System::wait_pdp_discovery() so it uses the topology to check which participant has discovered which, returning when all the necessary connections are established.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions