address other comments

Author: d-w-moore

irods/auth/pam_password.py

@@ -66,14 +66,22 @@ def get_pam_password_from_stdin(file_like_object = None):
 
 class _pam_password_ClientAuthState(authentication_base):
 
+    # Client define
+    AUTH_CLIENT_AUTH_REQUEST = "pam_password_auth_client_request"
+
+    # Server define
+    AUTH_AGENT_AUTH_REQUEST = "auth_agent_auth_request"
+
     def __init__(self,*_,check_ssl=True,**_kw):
         super().__init__(*_,**_kw)
         self.check_ssl = check_ssl
-        self._l = None
+        self._list_for_request_result_return = None
 
     def auth_client_start(self, request):
 
-        self._l = request.pop(CLIENT_GET_REQUEST_RESULT, False)
+        # This list reference is popped and cached for the purpose of returning the request_result value
+        # to the caller upon request.
+        self._list_for_request_result_return = request.pop(CLIENT_GET_REQUEST_RESULT, False)
 
         if self.check_ssl:
             if not isinstance(self.conn.socket, ssl.SSLSocket):
@@ -82,12 +90,13 @@ def auth_client_start(self, request):
 
         resp = request.copy()
 
-        obj = resp.pop(FORCE_PASSWORD_PROMPT, None)
+        password_input_obj = resp.pop(FORCE_PASSWORD_PROMPT, None)
 
-        if obj:
-            obj = None if isinstance(obj,(int,bool)) else obj
+        if password_input_obj:
+            if isinstance(password_input_obj,(int,bool)):
+                password_input_obj = None
             # Like with the C++ plugin, we offer the user a chance to enter a password.
-            resp[AUTH_PASSWORD_KEY] = get_pam_password_from_stdin(file_like_object = obj)
+            resp[AUTH_PASSWORD_KEY] = get_pam_password_from_stdin(file_like_object = password_input_obj)
         else:
             # Password from .irodsA in environment.
             if self.conn.account._auth_file:
@@ -100,12 +109,6 @@ def auth_client_start(self, request):
         resp[__NEXT_OPERATION__] = self.AUTH_CLIENT_AUTH_REQUEST
         return resp
 
-    # Client define
-    AUTH_CLIENT_AUTH_REQUEST = "pam_password_auth_client_request"
-
-    # Server define
-    AUTH_AGENT_AUTH_REQUEST = "auth_agent_auth_request"
-
     def pam_password_auth_client_request(self, request):
         server_req = request.copy()
         server_req[__NEXT_OPERATION__] = self.AUTH_AGENT_AUTH_REQUEST
@@ -123,8 +126,8 @@ def pam_password_auth_client_request(self, request):
             msg = "auth storage object was either not set, or allowed to expire prematurely."
             raise RuntimeError(msg)
 
-        if isinstance(self._l,list):
-            self._l[:] = (resp["request_result"],)
+        if isinstance(self._list_for_request_result_return,list):
+            self._list_for_request_result_return[:] = (resp["request_result"],)
 
         resp[__NEXT_OPERATION__] = self.perform_native_auth
         return resp