admin settings are too sticky

[d-w-moore]

Setting admin behavior for one session affects another.

import irods;s=irods.helpers.make_session()
sd1=irods.helpers.make_session()
with sd1:
  sd1a = sd1.data_objects.get('/tempZone/home/rodsuser1/a')
  sd1a.metadata(admin=True) # this line causes the "sticky" change
del sd1a,sd1

sd2=irods.helpers.make_session()
sd2a = sd2.data_objects.get('/tempZone/home/rodsuser1/a')
sd2a.metadata.set('a','b') # call causes  {ADMIN_KW:''} to be passed to server

The result is an INSUFFICIENT_PRIVILEGE_LEVEL from the server on the last line.

[trel]

we consider this a bug...

has this stickiness always been the case? if not, we should document when it changed to start doing this.

[d-w-moore]

we consider this a bug...

has this stickiness always been the case? if not, we should document when it changed to start doing this.

It wasn't a problem in v3.2.0, it was introduced in v3.3.0. And yes, it's definitely a bug.

[d-w-moore]

The point at which this broke (post v3.2.0 but pre v3.3.0 release) was this commit: 2ecc3a3

The __call__ method for MetadataManager was wrongly changing an iRODSSession class variable __kw. The fix is to make sure the instance has a member of the same name and type that shadows or replaces that class vafriable.