Bump golangci/golangci-lint-action from 6 to 7 (#288)

* Bump golangci/golangci-lint-action from 6 to 7

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 7.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v6...v7)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump golang-ci to `v2.0`, because `v1.*` is not supported by
golangci-lint-action `v7.0`

* Migrate `golangci-lint`'s configuration file to `v2`

* Fix golint findings

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Damyan Yordanov <[email protected]>

Author: dependabot[bot]

.github/workflows/lint.yml

@@ -15,6 +15,6 @@ jobs:
         with:
           go-version-file: 'go.mod'
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
-          version: v1.61
+          version: v2.0

.golangci.yml

@@ -1,42 +1,47 @@
+version: "2"
 run:
-  timeout: 10m
   allow-parallel-runners: true
-
-issues:
-  # don't skip warning about doc comments
-  # don't exclude the default set of lint
-  exclude-use-default: false
-  # restore some of the defaults
-  # (fill in the rest as needed)
-  exclude-rules:
-    - path: "plugins/*"
-      linters:
-        - dupl
-        - lll
-    - path: "internal/*"
-      linters:
-        - dupl
-        - lll
 linters:
-  disable-all: true
+  default: none
   enable:
     - copyloopvar
     - dupl
     - errcheck
+    - ginkgolinter
     - goconst
     - gocyclo
-    - gofmt
-    - goimports
-    - gosimple
     - govet
     - ineffassign
-    - ginkgolinter
     - lll
     - misspell
     - nakedret
     - prealloc
     - staticcheck
-    - typecheck
     - unconvert
     - unparam
     - unused
+  exclusions:
+    generated: lax
+    rules:
+      - linters:
+          - dupl
+          - lll
+        path: plugins/*
+      - linters:
+          - dupl
+          - lll
+        path: internal/*
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

plugins/httpboot/plugin_test.go

@@ -498,7 +498,7 @@ func TestCustomHTTPBootRequestedKnownIP(t *testing.T) {
 	time.Sleep(time.Second * 1)
 
 	ip := net.ParseIP(knownClientIP)
-	err, relayedRequest := createHTTPBootRequest(t, ip)
+	relayedRequest, err := createHTTPBootRequest(t, ip)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -509,7 +509,7 @@ func TestCustomHTTPBootRequestedKnownIP(t *testing.T) {
 
 func TestCustomHTTPBootRequestedKnownMAC(t *testing.T) {
 	ip := net.ParseIP(notKnownClientIP)
-	err, relayedRequest := createHTTPBootRequest(t, ip)
+	relayedRequest, err := createHTTPBootRequest(t, ip)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -520,7 +520,7 @@ func TestCustomHTTPBootRequestedKnownMAC(t *testing.T) {
 
 func TestCustomHTTPBootRequestedUnknownClient(t *testing.T) {
 	ip := net.ParseIP(notKnownClientIP)
-	err, relayedRequest := createHTTPBootRequest(t, ip)
+	relayedRequest, err := createHTTPBootRequest(t, ip)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -529,7 +529,7 @@ func TestCustomHTTPBootRequestedUnknownClient(t *testing.T) {
 	ensureBootURL(t, macAddress, relayedRequest, expectedDefaultCustomBootURL)
 }
 
-func createHTTPBootRequest(t *testing.T, clientIP net.IP) (error, *dhcpv6.RelayMessage) {
+func createHTTPBootRequest(t *testing.T, clientIP net.IP) (*dhcpv6.RelayMessage, error) {
 	tempDir := t.TempDir()
 	_ = Init6(*customConfig, tempDir)
 
@@ -552,7 +552,7 @@ func createHTTPBootRequest(t *testing.T, clientIP net.IP) (error, *dhcpv6.RelayM
 	if err != nil {
 		t.Fatal(err)
 	}
-	return err, relayedRequest
+	return relayedRequest, err
 }
 
 func ensureBootURL(t *testing.T, macAddress net.HardwareAddr, relayedRequest *dhcpv6.RelayMessage, expectedBootURL string) {

plugins/metal/plugin.go

@@ -338,7 +338,7 @@ func GetIPAMIPAddressForMACAddress(mac net.HardwareAddr, subnetFamily ipamv1alph
 		return nil, fmt.Errorf("failed to list IPs: %v", err)
 	}
 
-	sanitizedMAC := strings.Replace(strings.ToLower(mac.String()), ":", "", -1)
+	sanitizedMAC := strings.ReplaceAll(strings.ToLower(mac.String()), ":", "")
 	for _, ip := range ips.Items {
 		if ip.Labels["mac"] == sanitizedMAC && ipFamilyMatches(ip, subnetFamily) {
 			return &ip.Status.Reserved.Net, nil

plugins/metal/plugin_test.go

@@ -37,7 +37,7 @@ var _ = Describe("Endpoint", func() {
 		linkLocalIPV6Addr, err := eui64.ParseMAC(i, m)
 		Expect(err).NotTo(HaveOccurred())
 
-		sanitizedMAC := strings.Replace(mac, ":", "", -1)
+		sanitizedMAC := strings.ReplaceAll(mac, ":", "")
 		ipv6Addr, err := ipamv1alpha1.IPAddrFromString(linkLocalIPV6Addr.String())
 		Expect(err).NotTo(HaveOccurred())
 		ipv6 := &ipamv1alpha1.IP{

plugins/oob/k8s.go

@@ -250,7 +250,7 @@ func (k K8sClient) doCreateIpamIP(
 			createdIpamIP := ipamIP.DeepCopy()
 			err := k.Client.Get(k.Ctx, client.ObjectKeyFromObject(createdIpamIP), createdIpamIP)
 			if err != nil && !apierrors.IsNotFound(err) {
-				return nil, fmt.Errorf("Failed to get IP %s/%s: %w", createdIpamIP.Namespace, createdIpamIP.Name, err)
+				return nil, fmt.Errorf("failed to get IP %s/%s: %w", createdIpamIP.Namespace, createdIpamIP.Name, err)
 			}
 			return createdIpamIP, nil
 		}