Remove CGO build flag (#698)

Author: friegger

.github/workflows/release-drafter.yml

@@ -5,7 +5,7 @@ on:
     branches:
       - main
       - release-**
-  pull_request_target:
+  pull_request:
     types: [ opened, reopened, synchronize ]
   workflow_dispatch:
 
@@ -22,13 +22,14 @@ jobs:
     steps:
       # Labels PRs based on branch, title, files, and body patterns
       - uses: release-drafter/release-drafter/autolabeler@v7
-        if: github.event_name == 'pull_request_target'
+        if: github.event_name == 'pull_request'
         with:
           config-name: release-drafter.yml
           token: ${{ secrets.GITHUB_TOKEN }}
       # Drafts your next Release notes as Pull Requests are merged into "main"
       # or a release branch
       - uses: release-drafter/release-drafter@v7
+        if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'
         with:
           config-name: release-drafter.yml
           token: ${{ secrets.GITHUB_TOKEN }}

Dockerfile

@@ -39,13 +39,13 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
 
 RUN --mount=type=cache,target=/root/.cache/go-build \
     --mount=type=cache,target=/go/pkg \
-    CGO_ENABLED=0 GOOS=$TARGETOS GOARCH=$TARGETARCH GO111MODULE=on go build -ldflags="${LDFLAGS}" -a -o libvirt-provider ./cmd/libvirt-provider/main.go
+    GOOS=$TARGETOS GOARCH=$TARGETARCH GO111MODULE=on go build -ldflags="${LDFLAGS}" -a -o libvirt-provider ./cmd/libvirt-provider/main.go
 
 
 # Install irictl-machine
 RUN --mount=type=cache,target=/root/.cache/go-build \
     --mount=type=cache,target=/go/pkg \
-    CGO_ENABLED=0 GOOS=$TARGETOS GOARCH=$TARGETARCH GO111MODULE=on \
+    GOOS=$TARGETOS GOARCH=$TARGETARCH GO111MODULE=on \
     go install github.com/ironcore-dev/ironcore/irictl-machine/cmd/irictl-machine@main
 
 # Ensure the binary is in a common location

Makefile

@@ -87,11 +87,11 @@ vet: ## Run go vet against code.
 
 .PHONY: lint
 lint: golangci-lint ## Run golangci-lint against code.
-	CGO_ENABLED=1 $(GOLANGCI_LINT) run
+	$(GOLANGCI_LINT) run
 
 .PHONY: lint-fix
 lint-fix: golangci-lint ## Run golangci-lint linter and perform fixes
-	CGO_ENABLED=1 $(GOLANGCI_LINT) run --fix
+	$(GOLANGCI_LINT) run --fix
 
 .PHONY: check
 check: manifests generate fmt check-license lint test ## Generate manifests, code, lint, check licenses, test
@@ -119,7 +119,7 @@ clean-docs: ## Remove all local mkdocs Docker images (cleanup).
 
 .PHONY: build
 build: manifests generate fmt vet add-license lint ## Build the binary
-	CGO_ENABLED=1 go build -o $(LIBVIRT_PROVIDER_BIN) $(LIBVIRT_PROVIDER_BIN_SOURCE)
+	go build -o $(LIBVIRT_PROVIDER_BIN) $(LIBVIRT_PROVIDER_BIN_SOURCE)
 
 .PHONY: run
 run: manifests generate fmt vet ## Run the binary