Remove condition migration logic after next release

[coderabbitai]

Summary

As part of PR #795 (centralize and harmonize condition/reason constants across controllers), a temporary condition migration layer was introduced to rename legacy condition type strings on existing CRs in-place during reconciliation. This migration logic is marked with TODO: Remove this function in the next release once all CRs have been reconciled. and should be cleaned up once all CRs in the field have been reconciled with the new condition naming scheme.

What needs to be removed

The following items are marked for removal in the next release:

1. migrateConditionTypes helper function in internal/controller/helper.go (Lines 88–97)
2. legacyBMCSettingsConditionTypes map + migration call in internal/controller/bmcsettings_controller.go (Line 81)
3. legacyBMCVersionConditionTypes map + migration call in internal/controller/bmcversion_controller.go (Line 72)
4. legacyBIOSVersionConditionTypes map + migration call in internal/controller/biosversion_controller.go (Line 81)
5. legacyBIOSSettingsConditionTypes map + migrateLegacyConditions method in internal/controller/biossettings_controller.go (Lines 114–126)

Prerequisites

Before removing the migration logic, ensure that:

• Sufficient time has passed for all existing CRs to be reconciled with the updated condition type strings introduced in PR Centralize and harmonize condition/reason constants across controllers #795.
• Any documentation or migration guides referencing the old condition names have been updated.

References

• PR Centralize and harmonize condition/reason constants across controllers #795: Centralize and harmonize condition/reason constants across controllers #795
• Requested by: @afritzler