Add hostname to NetworkInterface object

Signed-off-by: Guvenc Gulce <[email protected]>

Author: guvenc

.github/workflows/publish-docker.yml

@@ -17,6 +17,7 @@ on:
     paths-ignore:
       - 'docs/**'
       - '**/*.md'
+    types: [labeled, unlabeled, opened, synchronize, reopened]
 
 jobs:
   buildAndPush:
@@ -60,7 +61,6 @@ jobs:
           version: latest
           endpoint: builders # self-hosted
       - name: Login to GHCR
-        if: github.event_name != 'pull_request'
         uses: docker/login-action@v3
         with:
           registry: ghcr.io
@@ -72,6 +72,6 @@ jobs:
         with:
           context: .
           platforms: ${{env.platforms}}
-          push: ${{ github.event_name != 'pull_request' }}
+          push: ${{ (github.event_name == 'push' && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v'))) || (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'ok-to-image')) }}
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}

api/v1alpha1/networkinterface_types.go

@@ -40,6 +40,8 @@ type NetworkInterfaceSpec struct {
 	FirewallRules []FirewallRule `json:"firewallRules,omitempty"`
 	// MeteringRate are the metering parameters to be applied to this interface.
 	MeteringRate *MeteringParameters `json:"meteringRate,omitempty"`
+	// Hostname is the hostname which should be announced by the network interface.
+	Hostname *string `json:"hostname,omitempty"`
 }
 
 // NetworkInterfaceStatus defines the observed state of NetworkInterface

api/v1alpha1/zz_generated.deepcopy.go

@@ -168,6 +168,10 @@ spec:
                   - ipFamily
                   type: object
                 type: array
+              hostname:
+                description: Hostname is the hostname which should be announced by
+                  the network interface.
+                type: string
               ipFamilies:
                 description: |-
                   IPFamilies defines which IPFamilies this NetworkInterface is supporting

config/crd/bases/networking.metalnet.ironcore.dev_networkinterfaces.yaml

@@ -133,6 +133,7 @@ var _ = Describe("Network Controller", Label("network"), Ordered, func() {
 							Addr: netip.MustParseAddr("10.0.0.3"),
 						},
 					},
+					Hostname: &testHost,
 				},
 			}
 

controllers/controller_test.go

@@ -1245,6 +1245,8 @@ func (r *NetworkInterfaceReconciler) getInterfaceMeteringParams(nic *metalnetv1a
 
 func (r *NetworkInterfaceReconciler) applyInterface(ctx context.Context, log logr.Logger, nic *metalnetv1alpha1.NetworkInterface, vni uint32) (*ghw.PCIAddress, netip.Addr, bool, error) {
 	log.V(1).Info("Getting dpdk interface")
+	var hostName = ""
+
 	iface, err := r.DPDK.GetInterface(ctx, string(nic.UID))
 	if err != nil {
 		if !dpdkerrors.IsStatusErrorCode(err, dpdkerrors.NOT_FOUND) {
@@ -1277,6 +1279,10 @@ func (r *NetworkInterfaceReconciler) applyInterface(ctx context.Context, log log
 			return nil, netip.Addr{}, false, fmt.Errorf("error getting metering params: %w", err)
 		}
 
+		if nic.Spec.Hostname != nil {
+			hostName = *nic.Spec.Hostname
+		}
+
 		iface, err := r.DPDK.CreateInterface(ctx, &dpdk.Interface{
 			InterfaceMeta: dpdk.InterfaceMeta{ID: string(nic.UID)},
 			Spec: dpdk.InterfaceSpec{
@@ -1285,6 +1291,7 @@ func (r *NetworkInterfaceReconciler) applyInterface(ctx context.Context, log log
 				IPv4:     &primaryIpv4,
 				IPv6:     &primaryIpv6,
 				Metering: meteringParams,
+				HostName: hostName,
 			},
 		})
 		if err != nil {

controllers/networkinterface_controller.go

@@ -46,6 +46,7 @@ var (
 	ctxGrpc            context.Context
 	dpserviceAddr      string = "127.0.0.1:1337"
 	testNode           string = "testNode"
+	testHost           string = "testhost"
 	metalnetDir        string = "/tmp/var/lib/metalnet"
 	netFnsManager      *netfns.Manager
 	conn               *grpc.ClientConn

controllers/suite_test.go

@@ -6,7 +6,7 @@ require (
 	github.com/go-logr/logr v1.4.2
 	github.com/hashicorp/go-version v1.7.0
 	github.com/ironcore-dev/controller-utils v0.9.3
-	github.com/ironcore-dev/dpservice/go/dpservice-go v0.3.11
+	github.com/ironcore-dev/dpservice/go/dpservice-go v0.3.16
 	github.com/ironcore-dev/ironcore v0.1.2
 	github.com/ironcore-dev/metalbond v0.3.5
 	github.com/jaypipes/ghw v0.12.0

go.mod

@@ -63,6 +63,10 @@ github.com/ironcore-dev/controller-utils v0.9.3 h1:sTrnxSzX5RrLf4B8KrAH2axSC+gxf
 github.com/ironcore-dev/controller-utils v0.9.3/go.mod h1:djKnxDs0Hwxhhc0VmVY8tZnrOrElvrRV2jov/LiCZ2Y=
 github.com/ironcore-dev/dpservice/go/dpservice-go v0.3.11 h1:m+enb4dHIfhL6s5ca5PFNq6leLnb1nvmXefIRyGlsgE=
 github.com/ironcore-dev/dpservice/go/dpservice-go v0.3.11/go.mod h1:d5x2tPmu1yqrVHac/FvL+MFOeEb3IT4gn7Bj4+Xkj8M=
+github.com/ironcore-dev/dpservice/go/dpservice-go v0.3.14-0.20250408102508-69f164478fe9 h1:Nz5L0DkFGyzn8qSpf3gkHUO+ATXTMv7oRhjXjAq2Nbw=
+github.com/ironcore-dev/dpservice/go/dpservice-go v0.3.14-0.20250408102508-69f164478fe9/go.mod h1:d5x2tPmu1yqrVHac/FvL+MFOeEb3IT4gn7Bj4+Xkj8M=
+github.com/ironcore-dev/dpservice/go/dpservice-go v0.3.16 h1:gRd8IUsbMhN+5ZU9Ql8E+7lR88VKVmSKmIF0w2lCc14=
+github.com/ironcore-dev/dpservice/go/dpservice-go v0.3.16/go.mod h1:d5x2tPmu1yqrVHac/FvL+MFOeEb3IT4gn7Bj4+Xkj8M=
 github.com/ironcore-dev/ironcore v0.1.2 h1:zYxKEZ+xXeQ7KVBPgYj+W3D4mlR6sCVJaFKUzfuR204=
 github.com/ironcore-dev/ironcore v0.1.2/go.mod h1:ircFIizjXLGUU2r5utcYe/feMnwMZVJuyFZGAWmsmLQ=
 github.com/ironcore-dev/metalbond v0.3.5 h1:H+kXba0F/m2rjcAClU0I8Am/gBsFOQkf5icJBC2S8/I=