slight improvements to keyboardwidget & co

Author: isXander

src/main/java/dev/isxander/controlify/screenkeyboard/KeyboardWidget.java

@@ -56,25 +56,30 @@ public KeyboardWidget(Screen screen, int x, int y, int width, int height, KeyPre
 
     @Override
     protected void renderWidget(GuiGraphics guiGraphics, int mouseX, int mouseY, float partialTick) {
-        Blit.drawSpecial(guiGraphics, bufferSource -> {
+        for (T key : keys) {
+            // vanilla widget render does other stuff like mouse hover update etc
+            // render method of keys are empty - this doesn't actually do any rendering
+            key.render(guiGraphics, mouseX, mouseY, partialTick);
+        }
+
+        // draw in a managed context so we can batch render calls
+        // everything within here is rendered in a single draw call
+        Blit.drawManaged(guiGraphics, bufferSource -> {
             guiGraphics.fill(getX(), getY(), getX() + getWidth(), getY() + getHeight(), 0x80000000);
             guiGraphics.renderOutline(getX(), getY(), getWidth(), getHeight(), 0xFFAAAAAA);
 
-            for (T key : keys) {
-                // doesn't do any actual rendering
-                key.render(guiGraphics, mouseX, mouseY, partialTick);
-            }
-
             ControlifyVertexConsumer vertexConsumer = ControlifyVertexConsumer.of(
                     bufferSource.getBuffer(ExtraRenderTypes.guiTextured(Key.SPRITE.atlas()))
             );
-
             for (T key : keys) {
+                // every key background is rendered into the same vertex buffer to upload at once
                 Matrix4f pose = guiGraphics.pose().last().pose();
                 key.renderKeyBackground(vertexConsumer, pose, mouseX, mouseY, partialTick);
             }
 
+            // renders all foreground after background to prevent context switching
             for (T key : keys) {
+                // text rendering is batched by default in managed mode
                 key.renderKeyForeground(guiGraphics, mouseX, mouseY, partialTick);
             }
         });

src/main/java/dev/isxander/controlify/utils/render/Blit.java

@@ -1,6 +1,5 @@
 package dev.isxander.controlify.utils.render;
 
-import com.mojang.blaze3d.systems.RenderSystem;
 import dev.isxander.controlify.utils.ColorUtils;
 import net.minecraft.client.gui.GuiGraphics;
 import net.minecraft.client.renderer.*;
@@ -10,7 +9,7 @@
 import java.util.function.Consumer;
 
 public final class Blit {
-    public static void drawSpecial(GuiGraphics graphics, Consumer<MultiBufferSource> consumer) {
+    public static void drawManaged(GuiGraphics graphics, Consumer<MultiBufferSource> consumer) {
         //? if >=1.21.2 {
         graphics.drawSpecial(consumer);
         //?} else {

src/main/java/dev/isxander/controlify/utils/render/SpriteUtils.java

@@ -6,7 +6,7 @@
 
 public class SpriteUtils {
     public static void blitSprite(GuiGraphics graphics, ControlifySprite sprite, int x, int y, int width, int height) {
-        Blit.drawSpecial(graphics, multiBufferSource -> {
+        Blit.drawManaged(graphics, multiBufferSource -> {
             blitSprite(multiBufferSource, graphics.pose().last().pose(), sprite, x, y, width, height);
         });
     }