Fix buttons stuck focusing after clicking the mouse.

Author: isXander

build.gradle.kts

@@ -16,7 +16,7 @@ plugins {
 val ciRun = System.getenv().containsKey("GITHUB_ACTIONS")
 
 group = "dev.isxander"
-version = "2.3.0"
+version = "2.3.1"
 
 if (ciRun)
     version = "$version+${grgit.branch.current().name.replace('/', '.')}-SNAPSHOT"

changelogs/2.3.1.md

@@ -0,0 +1 @@
+- Fix buttons stuck focusing after clicking the mouse.

src/client/java/dev/isxander/yacl/gui/ElementListWidgetExt.java

@@ -3,6 +3,7 @@
 import com.mojang.blaze3d.vertex.PoseStack;
 import net.minecraft.client.Minecraft;
 import net.minecraft.client.gui.components.ContainerObjectSelectionList;
+import net.minecraft.client.gui.components.events.GuiEventListener;
 import net.minecraft.util.Mth;
 import org.jetbrains.annotations.Nullable;
 
@@ -92,6 +93,17 @@ protected E getEntryAtPosition(double x, double y) {
         return null;
     }
 
+    @Override
+    public boolean mouseReleased(double mouseX, double mouseY, int button) {
+        // on mouseClicked, the clicked element becomes focused so you can drag. on release, we should clear the focus
+        boolean clicked = super.mouseReleased(mouseX, mouseY, button);
+        if (getFocused() != null) {
+            this.getFocused().setFocused(null);
+            this.setFocused(null);
+        }
+        return clicked;
+    }
+
     /*
       below code is licensed from cloth-config under LGPL3
       modified to inherit vanilla's EntryListWidget and use yarn mappings

src/client/java/dev/isxander/yacl/gui/OptionListWidget.java

@@ -149,6 +149,13 @@ public boolean mouseClicked(double mouseX, double mouseY, int button) {
         return super.mouseClicked(mouseX, mouseY, button);
     }
 
+    @Override
+    public void mouseMoved(double mouseX, double mouseY) {
+        if (getFocused() instanceof OptionEntry optionEntry)
+            optionEntry.widget.unfocus();
+        setFocused(null);
+    }
+
     @Override
     public boolean mouseScrolled(double mouseX, double mouseY, double amount) {
         super.mouseScrolled(mouseX, mouseY, amount);

src/client/java/dev/isxander/yacl/gui/controllers/BooleanController.java

@@ -142,7 +142,7 @@ protected Component getValueText() {
 
         @Override
         public boolean keyPressed(int keyCode, int scanCode, int modifiers) {
-            if (!focused) {
+            if (!isFocused()) {
                 return false;
             }