Fix bugs in app review request

Author: isaaclyman

ios/Podfile.lock

@@ -1,39 +1,52 @@
 PODS:
   - Flutter (1.0.0)
+  - in_app_review (2.0.0):
+    - Flutter
   - integration_test (0.0.1):
     - Flutter
   - isar_flutter_libs (1.0.0):
     - Flutter
   - path_provider_foundation (0.0.1):
     - Flutter
     - FlutterMacOS
+  - shared_preferences_foundation (0.0.1):
+    - Flutter
+    - FlutterMacOS
   - url_launcher_ios (0.0.1):
     - Flutter
 
 DEPENDENCIES:
   - Flutter (from `Flutter`)
+  - in_app_review (from `.symlinks/plugins/in_app_review/ios`)
   - integration_test (from `.symlinks/plugins/integration_test/ios`)
   - isar_flutter_libs (from `.symlinks/plugins/isar_flutter_libs/ios`)
   - path_provider_foundation (from `.symlinks/plugins/path_provider_foundation/darwin`)
+  - shared_preferences_foundation (from `.symlinks/plugins/shared_preferences_foundation/darwin`)
   - url_launcher_ios (from `.symlinks/plugins/url_launcher_ios/ios`)
 
 EXTERNAL SOURCES:
   Flutter:
     :path: Flutter
+  in_app_review:
+    :path: ".symlinks/plugins/in_app_review/ios"
   integration_test:
     :path: ".symlinks/plugins/integration_test/ios"
   isar_flutter_libs:
     :path: ".symlinks/plugins/isar_flutter_libs/ios"
   path_provider_foundation:
     :path: ".symlinks/plugins/path_provider_foundation/darwin"
+  shared_preferences_foundation:
+    :path: ".symlinks/plugins/shared_preferences_foundation/darwin"
   url_launcher_ios:
     :path: ".symlinks/plugins/url_launcher_ios/ios"
 
 SPEC CHECKSUMS:
   Flutter: e0871f40cf51350855a761d2e70bf5af5b9b5de7
+  in_app_review: a31b5257259646ea78e0e35fc914979b0031d011
   integration_test: 252f60fa39af5e17c3aa9899d35d908a0721b573
   isar_flutter_libs: fdf730ca925d05687f36d7f1d355e482529ed097
   path_provider_foundation: 2b6b4c569c0fb62ec74538f866245ac84301af46
+  shared_preferences_foundation: fcdcbc04712aee1108ac7fda236f363274528f78
   url_launcher_ios: 5334b05cef931de560670eeae103fd3e431ac3fe
 
 PODFILE CHECKSUM: 819463e6a0290f5a72f145ba7cde16e8b6ef0796

lib/util/app_review.dart

@@ -17,20 +17,18 @@ Future bkMaybeRequestReview() async {
     return;
   }
 
-  var requested = prefs.getStringWithDefault(
-      requestedDateKey, DateTime.now().toIso8601String());
-
-  var requestedDate = DateTime.tryParse(requested);
-  if (requestedDate == null) {
+  var timeSinceInstallation = DateTime.now().difference(installedDate);
+  if (timeSinceInstallation.inDays < 7) {
     return;
   }
 
-  var timeSinceInstallation = DateTime.now().difference(installedDate);
-  var timeSinceLastRequest = DateTime.now().difference(requestedDate);
+  final requested = prefs.getString(requestedDateKey);
+  final requestedDate = requested == null ? null : DateTime.tryParse(requested);
+  final shouldRequest = requestedDate == null ||
+      DateTime.now().difference(requestedDate).inDays > 14;
 
-  if (timeSinceInstallation.inDays > 7 &&
-      timeSinceLastRequest.inDays > 14 &&
-      await inAppReview.isAvailable()) {
+  if (shouldRequest && await inAppReview.isAvailable()) {
+    await prefs.setString(requestedDateKey, DateTime.now().toIso8601String());
     await inAppReview.requestReview();
   }
 }

pubspec.yaml

@@ -1,7 +1,7 @@
 name: bookoscope
 description: OPDS crawl & search + free ebooks
 publish_to: "none"
-version: 1.4.1+9
+version: 1.4.2+10
 
 environment:
   sdk: ">=3.1.0 <4.0.0"