Tiled-listing view for news broken on migration

[sauzher]

https://isaw-migration.jazkarta.com/news

 https://isaw-migration.jazkarta.com/news/tiled-listing
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module Products.Five.browser.metaconfigure, line 485, in __call__
  Module Products.Five.browser.pagetemplatefile, line 125, in __call__
  Module Products.Five.browser.pagetemplatefile, line 59, in __call__
  Module zope.pagetemplate.pagetemplate, line 137, in pt_render
  Module five.pt.engine, line 98, in __call__
  Module z3c.pt.pagetemplate, line 176, in render
  Module chameleon.zpt.template, line 261, in render
  Module chameleon.template, line 191, in render
  Module chameleon.template, line 171, in render
  Module f42ba5d016743cb75753d7cc35596344.py, line 983, in render
  Module 17beba01a0ac3e916d374251ec9ddcd0.py, line 1167, in render_master
  Module 17beba01a0ac3e916d374251ec9ddcd0.py, line 364, in render_content
  Module f42ba5d016743cb75753d7cc35596344.py, line 971, in __fill_content_core
  Module f42ba5d016743cb75753d7cc35596344.py, line 375, in render_content_core
  Module five.pt.expressions, line 154, in __call__
  Module five.pt.expressions, line 126, in traverse
  Module zope.traversing.adapters, line 142, in traversePathElement
   - __traceback_info__: (None, 'tag')
  Module zope.traversing.adapters, line 56, in traverse
   - __traceback_info__: (None, 'tag', ())
LocationError: (None, 'tag')

 - Expression: "image_thumb/tag"
 - Filename:   ... rc/isaw.theme/isaw/theme/browser/templates/tiled_view.pt
 - Location:   (line 72: col 28)
 - Source:     image_tag image_thumb/tag;
                         ^^^^^^^^^^^^^^^
 - Arguments:  repeat: {...} (0)
               template: <ViewPageTemplateFile - at 0xf7756b351310>
               views: <ViewMapper - at 0xf7756b351410>
               modules: <instance - at 0xf775806d7550>
               args: <tuple - at 0xf77581280050>
               here: <ImplicitAcquisitionWrapper news at 0xf7756b2d0460>
               user: <ImplicitAcquisitionWrapper - at 0xf7756b2d0cd0>
               loop: {...} (1)
               nothing: <NoneType - at 0xc5fa4de772e0>
               translate: <function translate at 0xf7756adc00d0>
               container: <ImplicitAcquisitionWrapper news at 0xf7756b2d0460>
               request: <instance - at 0xf7756b2813c0>
               wrapped_repeat: <SafeMapping - at 0xf7756b21d770>
               traverse_subpath: <list - at 0xf7756b706050>
               default: <object - at 0xf77580235950>
               context: <ImplicitAcquisitionWrapper news at 0xf7756b2d0460>
               view: <SimpleViewClass from /usr/local/plone-5.1/migration/src/isaw.theme/isaw/theme/browser/templates/tiled_view.pt tiled-listing at 0xf7756b34dfd0>
               target_language: <NoneType - at 0xc5fa4de772e0>
               root: <ImplicitAcquisitionWrapper Zope at 0xf7756b2810f0>
               options: {...} (0)

[sauzher]

The view partially works in plone52 (python2).

The "view more" button needs fixes, though

2025-12-09 11:37:16,547 ERROR   [Zope.SiteErrorLog:252][waitress-2] 1765298236.550.0448207292618 http://localhost:8081/isaw/news/@@tiled-listing-page
Traceback (innermost last):
  Module ZPublisher.WSGIPublisher, line 176, in transaction_pubevents
  Module ZPublisher.WSGIPublisher, line 385, in publish_module
  Module ZPublisher.WSGIPublisher, line 288, in publish
  Module ZPublisher.mapply, line 85, in mapply
  Module ZPublisher.WSGIPublisher, line 63, in call_object
  Module zope.browserpage.simpleviewclass, line 41, in __call__
  Module Products.Five.browser.pagetemplatefile, line 126, in __call__
  Module Products.Five.browser.pagetemplatefile, line 61, in __call__
  Module zope.pagetemplate.pagetemplate, line 135, in pt_render
  Module Products.PageTemplates.engine, line 378, in __call__
  Module z3c.pt.pagetemplate, line 176, in render
  Module chameleon.zpt.template, line 302, in render
  Module chameleon.template, line 215, in render
  Module chameleon.template, line 192, in render
  Module 16ea5e64a8ffa1e9d986b83a716d339a, line 158, in render
  Module zope.tales.expressions, line 250, in __call__
  Module Products.PageTemplates.Expressions, line 217, in _eval
  Module zope.tales.expressions, line 153, in _eval
  Module Products.PageTemplates.Expressions, line 134, in trustedBoboAwareZopeTraverse
  Module zope.traversing.adapters, line 146, in traversePathElement
   - __traceback_info__: (<Products.ZCatalog.Catalog.mybrains object at 0x7faaab4e3230>, "@@images\n                  image_thumb python:scales.scale('image', width=170, height=130)")
  Module zope.traversing.namespace, line 165, in namespaceLookup
  Module Products.CMFPlone.earlypatches.security, line 15, in traverse
  Module zope.traversing.namespace, line 421, in traverse
LocationError: (<Products.ZCatalog.Catalog.mybrains object at 0x7faaab4e3230>, "images\n                  image_thumb python:scales.scale('image', width=170, height=130)")

 - Expression: " item/@@images
                  image_thumb python:scales.scale('image', width=170, height=130"
 - Filename:   ... w.theme/isaw/theme/browser/templates/tiled_list_items.pt
 - Location:   (line 4: col 24)
 - Source:     ... item/@@images
                  ^
 - Arguments:  default: <DEFAULT>
               repeat: <Products.PageTemplates.engine.RepeatDictWrapper object at 0x7faaab4e1910>
               template: <Products.Five.browser.pagetemplatefile.ViewPageTemplateFile object at 0x7faaab5c5cd0>
               views: <Products.Five.browser.pagetemplatefile.ViewMapper object at 0x7faaab5c5b10>
               request: <WSGIRequest, URL=http://localhost:8081/isaw/news/@@tiled-listing-page>
               args: ()
               here: <Folder at /isaw/news>
               translate: <function translate at 0x7faaab475750>
               user: <PropertiedUser 'admin-sauzher'>
               nothing: None
               item_url: 'http://localhost:8081/isaw/news/deborah-klimburg-salter-to-give-lecture-at-isaw'
               container: <Folder at /isaw/news>
               items: <Products.CMFPlone.PloneBatch.Batch object at 0x7faaab761f10>
               modules: <Products.PageTemplates.ZRPythonExpr._SecureModuleImporter object at 0x7faae1014e90>
               traverse_subpath: []
               item: <Products.ZCatalog.Catalog.mybrains object at 0x7faaab4e3230>
               loop: {u'item': <Products.PageTemplates.engine.RepeatItem object at 0x7faaab557810>}
               context: <Folder at /isaw/news>
               view: <Products.Five.browser.metaconfigure.SimpleViewClass from /mnt/hdd3/projects/isaw4/isaw.web51/src/isaw.theme/isaw/theme/browser/templates/tiled_list_items.pt object at 0x7faaab5c5e50>
               target_language: None
               root: <Application at >
               options: {}
               attrs: {}

[alecpm]

@sauzher @paregorios This should be fixed now. I did notice a migration related bug where the default page for /news had been de-selected during the migration. It should have been /news/collector, but it was just displaying the tiled listing of the /news folder itself. Seems like a bug in the migration scripts. I manually updated it and also fixed the template, updated the available collection and folder views, and added the cropping behavior to the types it was missing from.

[sauzher]

thanks @alecpm I ran again the migration from staging and I've applied upgrade steps you wrote.

The view works but the "view more" button has still something wrong.

[alecpm]

@sauzher should be fixed now. We could probably make these views more efficient by just checking the brain to see if an image exists and then using ./@@images/image/blogtile for the url instead of resolving the object from the brain, and then calling scale and tag on @@images, but that's probably unnecessary at this time.