Chrome's console value preview functionality spams the console commands

[benjameep]

Chrome recently added a value preview to their auto-completion.

So when typing the word help it auto-completes the word. And trying to preview the resulting value. Which calls the .toString method, spamming that function every-time you try to finish typing help

Is it possible detect who is calling the function, or use getters to only run the .toString function once enter is pressed?

[konklone]

Oh that is interesting! I can reproduce it easily. I am less sure how to fix it. But I will definitely look into this for this year.

[benjameep]

Could you do something like replacing

var say = function(){ 
   emit('chat', {message: message});
}

say.toString = function(){
   say(prompt("What do you want to say?"));
   return " ";
}

with

Object.defineProperty(window,'say',{
   value:function(){
      emit('chat', {message: message});
   },
   get:function(){
      this(prompt("What do you want to say?"));
   }
})

Because Chrome is a lot more careful about firing getters and setters

[konklone]

Hmm, this looks promising, though is new syntax to me. But I tried adapting the code to use it, and got this error:

(index):935 Uncaught TypeError: Invalid property descriptor. Cannot both specify accessors and a value or writable attribute, #<Object>
    at Function.defineProperty (<anonymous>)
    at (index):935

That's with this code:

    Object.defineProperty(window,'say',{
       value:function(){
          if (!message) return;
          if (user.live.chat != "true") return;
          message = message.toString();

          said = true;
          emit('chat', {message: message});
          return blank();
       },

       // run without parens to use a popup dialog
       get:function(){
          this(prompt("What do you want to say?"));
          return " ";
       }
    })

[konklone]

For now, I've updated the site to remove all of the ()-less methods, and it now requires parens for all of them. :(