Skip to content

Commit 9da1f9e

Browse files
authored
privately link fmt, but propagate its header (#4779)
1 parent 1aa25b9 commit 9da1f9e

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

3rdparty/find_dependencies.cmake

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -994,10 +994,9 @@ if(USE_SYSTEM_FMT)
994994
endif()
995995
endif()
996996
if(NOT USE_SYSTEM_FMT)
997-
# We set the FMT_HEADER_ONLY macro, so no need to actually compile the source
998997
include(${Open3D_3RDPARTY_DIR}/fmt/fmt.cmake)
999998
open3d_import_3rdparty_library(3rdparty_fmt
1000-
PUBLIC
999+
HEADER
10011000
INCLUDE_DIRS ${FMT_INCLUDE_DIRS}
10021001
LIB_DIR ${FMT_LIB_DIR}
10031002
LIBRARIES ${FMT_LIBRARIES}
@@ -1008,7 +1007,7 @@ if(NOT USE_SYSTEM_FMT)
10081007
target_compile_definitions(3rdparty_fmt INTERFACE FMT_USE_WINDOWS_H=0)
10091008
target_compile_definitions(3rdparty_fmt INTERFACE FMT_STRING_ALIAS=1)
10101009
endif()
1011-
list(APPEND Open3D_3RDPARTY_PUBLIC_TARGETS Open3D::3rdparty_fmt)
1010+
list(APPEND Open3D_3RDPARTY_HEADER_TARGETS Open3D::3rdparty_fmt)
10121011

10131012
# Pybind11
10141013
if (BUILD_PYTHON_MODULE)

0 commit comments

Comments
 (0)