TextureLoader: unlock surface on failure paths (#775)

madebr · web-flow · commit 4048e741bb73 · 2026-01-31T05:09:01.000Z
diff --git a/extensions/src/textureloader.cpp b/extensions/src/textureloader.cpp
@@ -64,6 +64,7 @@ bool TextureLoader::PatchTexture(LegoTextureInfo* p_textureInfo)
 	if (details->bits_per_pixel == 8) {
 		SDL_Palette* sdlPalette = SDL_GetSurfacePalette(surface);
 		if (!sdlPalette) {
+			p_textureInfo->m_surface->Unlock(desc.lpSurface);
 			SDL_DestroySurface(surface);
 			return false;
 		}
@@ -78,6 +79,7 @@ bool TextureLoader::PatchTexture(LegoTextureInfo* p_textureInfo)
 
 		LPDIRECTDRAWPALETTE ddPalette = nullptr;
 		if (pDirectDraw->CreatePalette(DDPCAPS_8BIT | DDPCAPS_ALLOW256, entries, &ddPalette, NULL) != DD_OK) {
+			p_textureInfo->m_surface->Unlock(desc.lpSurface);
 			SDL_DestroySurface(surface);
 			return false;
 		}

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@ bool TextureLoader::PatchTexture(LegoTextureInfo* p_textureInfo)`
`64`	`64`	`if (details->bits_per_pixel == 8) {`
`65`	`65`	`SDL_Palette* sdlPalette = SDL_GetSurfacePalette(surface);`
`66`	`66`	`if (!sdlPalette) {`
	`67`	`+ p_textureInfo->m_surface->Unlock(desc.lpSurface);`
`67`	`68`	`SDL_DestroySurface(surface);`
`68`	`69`	`return false;`
`69`	`70`	`}`
`@@ -78,6 +79,7 @@ bool TextureLoader::PatchTexture(LegoTextureInfo* p_textureInfo)`
`78`	`79`
`79`	`80`	`LPDIRECTDRAWPALETTE ddPalette = nullptr;`
`80`	`81`	`if (pDirectDraw->CreatePalette(DDPCAPS_8BIT \| DDPCAPS_ALLOW256, entries, &ddPalette, NULL) != DD_OK) {`
	`82`	`+ p_textureInfo->m_surface->Unlock(desc.lpSurface);`
`81`	`83`	`SDL_DestroySurface(surface);`
`82`	`84`	`return false;`
`83`	`85`	`}`