Can the current code in this repository be used for the decompilation of another software?

[gynt]

I really like the comparison tools in this repository. I tried searching the repo for "lego" to see to what extent the isledecomp project is "baked in" into this project. I didn't come to a conclusion so therefore I am asking here:

Can the current code in this repository be used for the decompilation of another software? Given that the other software is also x86 (32-bit), but not VC4 but rather something a bit more recent. How much mileage will I get by using this repository as-is?

Any input is welcome.

[jonschz]

(Almost) all Lego Island-specific code has been generalised. A generalisation to other msvc-projects of that era should be straightforward.

I am not sure how well the parsing of much more modern MSVC debug symbol dumps will work. As far as I am aware, this project will not very useful without being able to read the dumps. @disinvite @madebr do you have any insights here?

[disinvite]

It all depends on cvdump.exe generating text from the PDB analysis that our parser can read.

I don't see any specific PDB version over at microsoft/microsoft-pdb so it may just work. Only one way to find out.

If you do get errors or find things missing please let us know!

[madebr]

From what I've seen, our cvdump.exe exe can read both the old (max 64MiB) and new (max 4GiB) pdb file format.
As long as Microsoft does not add new types to the debug streams in new toolchains, it should just work.

[jonschz]

Also, feel free to ask questions if you struggle to set this up. The documentation / readmes can clearly be improved, and the best way to do that is to see where a new user gets stuck.

[gynt]

Wow, thank you all for the welcoming responses!

I guess we can make this a tracking issue? Where I post issues as I go?

• python -m pip install -e . Worked flawlessly, no issues here.
• The command reccmp-reccmp --verbose 0x100ae1a0 legobin/LEGO1.DLL build/LEGO1.DLL build/LEGO1.PDB . as defined here doesn't work on my binary. I get a usage message: reccmp-reccmp: error: one of the arguments --target --paths is required. Based on the usage message, I figured the correct invocation is: reccmp-reccmp --verbose 0x100ae1a0 --paths legobin/LEGO1.DLL build/LEGO1.DLL build/LEGO1.PDB .

[jonschz]

Correct! There also is a more modern way to run these commands, but it isn't documented yet (see #6). Feel free to post further issued here.

[gynt]

Running reccmp-reccmp I get the following:

AssertionError: Unhandled in union:     # members = 2,  field list type 0x22e2, SEALED, Size = 4        ,class name = <unnamed-tag>, unique name = .?AT<unnamed-tag>@@

If I look in the console output, the first error I get is:

[ERROR] Unmatched line in class:        Size = (LF_ULONG) 320996, class name = ViewportRenderState, unique name = .?AVViewportRenderState@@, UDT(0x00001056

I am running reccmp-reccmp on: the original binary, the recompiled binary (Release build), the Release build pdb file.

What should I look into to get this issue resolved?

I annotated my class function like this:
The game uses a single static instance of this class, so my recompilation does too.

class ViewportRenderState : ViewportRenderStateStruct {
    public:

    //FUNCTION: MYEXE 0x401000
    BOOL xyAreValid( uint x, uint y) {
        ....
    }
}