Merge pull request #36 from bummzack/fix-sorting-of-sitetree-subclasses

stevie-mayhew · stevie-mayhew · commit 9c329389e699 · 2015-11-04T07:31:25.000+13:00
Fixing automatic-sort of SiteTree subclasses.
diff --git a/code/ModelAdmin/CatalogPageAdmin.php b/code/ModelAdmin/CatalogPageAdmin.php
@@ -112,7 +112,7 @@ public function onAfterGridFieldRowSort($pages)
         }
         if ($model::config()->get('automatic_live_sort') == true) {
             foreach ($pages as $page) {
-                if(get_class($page) == $modelClass) {
+                if($page instanceof $modelClass) {
                     DB::query("UPDATE " . $modelClass . "_Live SET " . $model->getSortFieldname() . "=" . $page->{$model->getSortFieldname()} . " WHERE ID=" . $page->ID);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public function onAfterGridFieldRowSort($pages)`
`112`	`112`	`}`
`113`	`113`	`if ($model::config()->get('automatic_live_sort') == true) {`
`114`	`114`	`foreach ($pages as $page) {`
`115`		`- if(get_class($page) == $modelClass) {`
	`115`	`+ if($page instanceof $modelClass) {`
`116`	`116`	`DB::query("UPDATE " . $modelClass . "_Live SET " . $model->getSortFieldname() . "=" . $page->{$model->getSortFieldname()} . " WHERE ID=" . $page->ID);`
`117`	`117`	`}`
`118`	`118`	`}`