fix: use admin token for privatisation #1454
Conversation
| import { GitCommitResult } from "@root/types/gitfilesystem" | ||
| import { GitHubRepoInfo, RawGitTreeEntry, RepoState } from "@root/types/github" | ||
|
|
||
| import { E2E_TEST_GH_TOKEN } from "../middlewareServices/AuthenticationMiddlewareService" |
There was a problem hiding this comment.
do we actually have this token at run time or is it only during e2e on local
There was a problem hiding this comment.
Run time - we currently also use it for pr approval
There was a problem hiding this comment.
Not a blocker but The name of the token is very misleading
| // Privatising a repo is restricted to repo admins - an admin token will be inserted in via our axios interceptor | ||
| // Privatising a repo is restricted to repo admins - our main admin token is used | ||
| const headers = { | ||
| Authorization: "", |
There was a problem hiding this comment.
How come this was previously empty? Comment seems to say this was injected by the axios interceptor
If we are modifying to inject token here is the interceptor still needed
There was a problem hiding this comment.
interceptor always exists, and inserts in the token in cases where it doesn't exist (i.e. all email login actions). normally this is just to catch the github flow, where the user's personal github token wold be used (but they would lack perms)
In this case we're using the admin token for both flows, so no change
Uses our admin token to privatise repos, to fix github's changes to disallow write tokens to change repo status.