fix: add windowsPathsNoEscape to preserve behaviour on Windows

istanbuljs · Jun 10, 2024 · f9dca2b · f9dca2b
1 parent a1955c5
commit f9dca2b
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 102 deletions.
diff --git a/.taprc b/.taprc
@@ -1,3 +1,2 @@
 timeout: 360
-bail: true
 disable-coverage: true
diff --git a/index.js b/index.js
@@ -104,7 +104,7 @@ class TestExclude {
 
     globSync(cwd = this.cwd) {
         const globPatterns = getExtensionPattern(this.extension || []);
-        const globOptions = { cwd, nodir: true, dot: true };
+        const globOptions = { cwd, nodir: true, dot: true, posix: true };
         /* If we don't have any excludeNegated then we can optimize glob by telling
          * it to not iterate into unwanted directory trees (like node_modules). */
         if (this.excludeNegated.length === 0) {
@@ -118,7 +118,7 @@ class TestExclude {
 
     async glob(cwd = this.cwd) {
         const globPatterns = getExtensionPattern(this.extension || []);
-        const globOptions = { cwd, nodir: true, dot: true };
+        const globOptions = { cwd, nodir: true, dot: true, posix: true };
         /* If we don't have any excludeNegated then we can optimize glob by telling
          * it to not iterate into unwanted directory trees (like node_modules). */
         if (this.excludeNegated.length === 0) {

diff --git a/is-outside-dir-win32.js b/is-outside-dir-win32.js
@@ -3,7 +3,7 @@
 const path = require('path');
 const { minimatch } = require('minimatch');
 
-const dot = { dot: true };
+const dot = { dot: true, windowsPathsNoEscape: true };
 
 module.exports = function(dir, filename) {
     return !minimatch(path.resolve(dir, filename), path.join(dir, '**'), dot);

diff --git a/package-lock.json b/package-lock.json
diff --git a/test/glob.js b/test/glob.js
@@ -88,6 +88,7 @@ t.test('allows negated exclude patterns', t =>
     })
 );
 
+
 t.test('allows negated include patterns', t =>
     testHelper(t, {
         options: {
-Original file line number
+Diff line change
@@ Expand Up / @@ -88,6 +88,7 @@ t.test('allows negated exclude patterns', t => @@
         })
     );
     t.test('allows negated include patterns', t =>
         testHelper(t, {
             options: {
@@ Expand Down @@