fix(ZMS): remove redundant null checks for Psalm

Drop dead null coalescing on query string and null comparison on client IP where both values are already non-nullable strings.

Author: ThomasAFink

zmscitizenapi/src/Zmscitizenapi/Middleware/IpFilterMiddleware.php

@@ -31,7 +31,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
         try {
             $ip = ClientIpHelper::getClientIp();
             $uri = (string)$request->getUri();
-            if ($ip === null || !filter_var($ip, FILTER_VALIDATE_IP)) {
+            if (!filter_var($ip, FILTER_VALIDATE_IP)) {
                 $this->logger->logInfo('Invalid IP address detected', [
                     'ip' => $ip,
                     'uri' => $uri

zmsticketprinter/src/Zmsticketprinter/Index.php

@@ -112,7 +112,7 @@ private function getQueryStringWithLang()
         if (!strpos($queryString, 'lang=')) {
             $queryString .= '&lang=de';
         }
-        return str_replace('/&', '', $queryString ?? '');
+        return str_replace('/&', '', $queryString);
     }
 
     private function getTranslations($languageConfig, $currentLang)