Skip to content

Commit c6f1ed7

Browse files
Fix coderabbit issues
1 parent 719b4d6 commit c6f1ed7

File tree

3 files changed

+1
-19
lines changed

3 files changed

+1
-19
lines changed

src/app/app.component.spec.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
1111
import { HttpClient } from '@angular/common/http';
1212
import { TranslateHttpLoader } from '@ngx-translate/http-loader';
1313
import { SwUpdate } from '@angular/service-worker';
14-
import { MatSnackBarService } from '@global-service/mat-snack-bar/mat-snack-bar.service';
1514

1615
export function HttpLoaderFactory(httpClient: HttpClient) {
1716
return new TranslateHttpLoader(httpClient);
@@ -20,7 +19,6 @@ export function HttpLoaderFactory(httpClient: HttpClient) {
2019
describe('AppComponent', () => {
2120
let component: AppComponent;
2221
let fixture: ComponentFixture<AppComponent>;
23-
let matSnackBarMock: jasmine.SpyObj<MatSnackBarService>;
2422

2523
const localStorageMock = jasmine.createSpyObj('LocalStorageService', [
2624
'userIdBehaviourSubject',
@@ -34,7 +32,6 @@ describe('AppComponent', () => {
3432
const metaServiceMock = jasmine.createSpyObj('MetaService', ['setMetaOnRouteChange']);
3533

3634
beforeEach(waitForAsync(() => {
37-
matSnackBarMock = jasmine.createSpyObj('MatSnackBarService', ['openSnackBar']);
3835
TestBed.configureTestingModule({
3936
imports: [
4037
RouterTestingModule,
@@ -53,7 +50,6 @@ describe('AppComponent', () => {
5350
{ provide: LocalStorageService, useValue: localStorageMock },
5451
{ provide: MetaService, useValue: metaServiceMock },
5552
{ provide: SwUpdate, useValue: {} },
56-
{ provide: MatSnackBarService, useValue: matSnackBarMock }
5753
],
5854
declarations: [AppComponent]
5955
}).compileComponents();
@@ -68,16 +64,4 @@ describe('AppComponent', () => {
6864
it('should create', () => {
6965
expect(component).toBeTruthy();
7066
});
71-
72-
it('should show snackbar when network is offline', () => {
73-
spyOnProperty(navigator, 'onLine', 'get').and.returnValue(false);
74-
component.onNetworkStatusChange();
75-
expect(matSnackBarMock.openSnackBar).toHaveBeenCalledWith('noInternet');
76-
});
77-
78-
it('should NOT show snackbar when network is online', () => {
79-
spyOnProperty(navigator, 'onLine', 'get').and.returnValue(true);
80-
component.onNetworkStatusChange();
81-
expect(matSnackBarMock.openSnackBar).not.toHaveBeenCalled();
82-
});
8367
});

src/app/ubs/ubs-admin/components/ubs-admin-customers/customers-filters.interface.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ export interface FilterCustomers {
66
fromControl: string;
77
toControl: string;
88
isDate?: boolean;
9-
}
9+
}

src/app/ubs/ubs-admin/components/ubs-admin-customers/ubs-admin-customers.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import { ClientStatusEnum } from '@ubs/ubs/enums/client-status.enum';
3434
import { MatSelectChange } from '@angular/material/select';
3535
import { IAppState } from '../../../../store/state/app.state';
3636
import { ColumnParam, columnsParams } from '@ubs/ubs-admin/components/ubs-admin-customers/columnsParams.mock';
37-
import { TranslateService } from '@ngx-translate/core';
3837
import { DatePipe } from '@angular/common';
3938
import { FilterCustomers } from './customers-filters.interface';
4039

@@ -116,7 +115,6 @@ export class UbsAdminCustomersComponent implements OnInit, AfterViewChecked, OnD
116115
private readonly localStorageService: LocalStorageService,
117116
private readonly tableHeightService: TableHeightService,
118117
private readonly adminCustomerService: AdminCustomersService,
119-
private readonly translate: TranslateService
120118
) {}
121119

122120
ngOnInit() {

0 commit comments

Comments
 (0)