fix comments: avoid explicit type casting, sonar issues

Author: yuliiakaras

src/app/store/effects/bigOrderTable.effects.ts

@@ -142,7 +142,7 @@ export class BigOrderTableEffects {
           map((response) => {
             if (response.body) {
               this.snackBar.openSnackBar('changesSaved');
-              return UpdateOrderInfoSuccess({ updatedOrder: response.body as IBigOrderTableOrderInfo });
+              return UpdateOrderInfoSuccess({ updatedOrder: response.body });
             } else {
               this.snackBar.openSnackBar('error');
               return ReceivedFailure({ error: 'Failed to update order' });

src/app/ubs/ubs-admin/components/ubs-admin-order/ubs-admin-order.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit, OnDestroy, AfterContentChecked, ChangeDetectorRef, ViewChild, HostListener } from '@angular/core';
+import { Component, OnInit, OnDestroy, AfterContentChecked, ChangeDetectorRef, HostListener } from '@angular/core';
 import { FormArray, FormBuilder, FormControl, FormGroup, Validators } from '@angular/forms';
 import { ActivatedRoute, Params, Router } from '@angular/router';
 import { formatDate } from '@angular/common';
@@ -11,14 +11,12 @@ import { UbsAdminCancelModalComponent } from '../ubs-admin-cancel-modal/ubs-admi
 import { OrderService } from '../../services/order.service';
 import { LocalStorageService } from '@global-service/localstorage/local-storage.service';
 import {
-  IAddressExportDetails,
   IEmployee,
   IExportDetails,
   IGeneralOrderInfo,
   IOrderDetails,
   IOrderInfo,
   IOrderStatusInfo,
-  IPaymentInfo,
   IResponsiblePersons,
   IUpdateResponsibleEmployee,
   IUserInfo,
@@ -50,7 +48,6 @@ export class UbsAdminOrderComponent implements OnInit, OnDestroy, AfterContentCh
   private destroy$: Subject<boolean> = new Subject<boolean>();
   isOrderCancelledAfterFormed: boolean;
   orderForm: FormGroup;
-  isDataLoaded = false;
   orderId: number;
   orderInfo: IOrderInfo;
   generalInfo: IGeneralOrderInfo;
@@ -94,17 +91,17 @@ export class UbsAdminOrderComponent implements OnInit, OnDestroy, AfterContentCh
     return this.orderForm.controls.addressExportDetailsDto as FormControl;
   }
   constructor(
-    private translate: TranslateService,
-    private localStorageService: LocalStorageService,
-    private adminTableService: AdminTableService,
-    private fb: FormBuilder,
-    private dialog: MatDialog,
-    private route: ActivatedRoute,
-    private router: Router,
-    private changeDetector: ChangeDetectorRef,
-    private store: Store<IAppState>,
-    private actions$: Actions,
-    private orderService: OrderService,
+    private readonly translate: TranslateService,
+    private readonly localStorageService: LocalStorageService,
+    private readonly adminTableService: AdminTableService,
+    private readonly fb: FormBuilder,
+    private readonly dialog: MatDialog,
+    private readonly route: ActivatedRoute,
+    private readonly router: Router,
+    private readonly changeDetector: ChangeDetectorRef,
+    private readonly store: Store<IAppState>,
+    private readonly actions$: Actions,
+    private readonly orderService: OrderService,
     public ubsAdminEmployeeService: UbsAdminEmployeeService,
     public unsavedChangesGuard: UnsavedChangesGuard
   ) {}

src/app/ubs/ubs-admin/services/order.service.ts

@@ -1,4 +1,4 @@
-import { HttpClient } from '@angular/common/http';
+import { HttpClient, HttpResponse } from '@angular/common/http';
 import { Injectable } from '@angular/core';
 import { Observable } from 'rxjs';
 import {
@@ -10,7 +10,8 @@ import {
   ResponsibleEmployee,
   INotTakenOutReason,
   NotTakenOutReasonImages,
-  IOrderInfo
+  IOrderInfo,
+  IBigOrderTableOrderInfo
 } from '../models/ubs-admin.interface';
 import { environment } from '@environment/environment';
 import { IViolation } from '../models/violation.model';
@@ -97,7 +98,12 @@ export class OrderService {
     return this.http.get<IOrderInfo>(`${this.backend}/management/get-data-for-order/${orderId}`);
   }
 
-  updateOrderInfo(orderId: number, lang: string, data: object, images?: NotTakenOutReasonImages[]) {
+  updateOrderInfo(
+    orderId: number,
+    lang: string,
+    data: object,
+    images?: NotTakenOutReasonImages[]
+  ): Observable<HttpResponse<IBigOrderTableOrderInfo>> {
     const formData: FormData = new FormData();
     formData.append('updateOrderPageAdminDto', JSON.stringify(data));
 
@@ -107,9 +113,13 @@ export class OrderService {
       });
     }
 
-    return this.http.patch(`${this.backend}/management/update-order-page-admin-info/${orderId}?language=${lang}`, formData, {
-      observe: 'response'
-    });
+    return this.http.patch<IBigOrderTableOrderInfo>(
+      `${this.backend}/management/update-order-page-admin-info/${orderId}?language=${lang}`,
+      formData,
+      {
+        observe: 'response'
+      }
+    );
   }
 
   getIsOrderCancelledAfterFormed(orderId: number): Observable<boolean> {