fix: remove minimum PNG logo width check (#349)

publiccodeyml/publiccode.yml#301 clarified the logo requirements
to just SHOULD be in vector format, removing the prescriptive
raster fallback constraints (transparent PNG, minimum width).

Author: bfabio

validations.go

@@ -44,9 +44,6 @@ func init() {
 	}
 }
 
-// Despite the spec requires at least 1000px, we temporarily release this constraint to 120px.
-const minLogoWidth = 120
-
 func getBasicAuth(domain Domain) string {
 	if len(domain.BasicAuth) > 0 {
 		auth := domain.BasicAuth[rand.Intn(len(domain.BasicAuth))] //nolint:gosec,lll // G404: not security-sensitive, picks from pre-configured list
@@ -230,14 +227,9 @@ func (p *Parser) validLogo(u url.URL, network bool) (bool, error) {
 
 		defer f.Close()
 
-		image, _, err := image.DecodeConfig(f)
-		if err != nil {
+		if _, _, err := image.DecodeConfig(f); err != nil {
 			return false, fmt.Errorf("%w", err)
 		}
-
-		if image.Width < minLogoWidth {
-			return false, fmt.Errorf("invalid image size of %d (min %dpx of width): %s", image.Width, minLogoWidth, netutil.DisplayURL(&u)) //nolint:err113,lll // dynamic message with image dimensions
-		}
 	}
 
 	return true, nil

validations_test.go

@@ -1,12 +1,9 @@
 package publiccode
 
 import (
-	"image"
-	"image/png"
 	"net/http"
 	"net/http/httptest"
 	"net/url"
-	"os"
 	"strings"
 	"testing"
 )
@@ -200,31 +197,6 @@ func TestValidLogoRemoteDownloadFailure(t *testing.T) {
 	}
 }
 
-func TestValidLogoPNGTooSmall(t *testing.T) {
-	// Create a tiny valid PNG (1x1 pixel) which is smaller than minLogoWidth.
-	f, err := os.CreateTemp("", "tiny-*.png")
-	if err != nil {
-		t.Fatalf("can't create temp file: %v", err)
-	}
-	defer os.Remove(f.Name())
-
-	// Write a minimal 1x1 PNG.
-	png.Encode(f, image.NewRGBA(image.Rect(0, 0, 1, 1)))
-	f.Close()
-
-	p, _ := NewParser(ParserConfig{DisableNetwork: true})
-	u := url.URL{Scheme: "file", Path: f.Name()}
-	ok, err := p.validLogo(u, false)
-	if ok {
-		t.Error("expected false for tiny PNG")
-	}
-	if err == nil {
-		t.Error("expected error for too-small image")
-	}
-	if !strings.Contains(err.Error(), "invalid image size") {
-		t.Errorf("unexpected error: %v", err)
-	}
-}
 
 func TestIsReachableSuccess(t *testing.T) {
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {