`eliot.testing.check_for_errors` leaves `logger.messages` in an unpredictable state.

[tomprince]

It appears that it will serialize all messages, until the first one that does not validate, or none, if there are unflushed tracebacks.

[itamarst]

Thanks for the bug report!

Seems like it should always serialize all messages and just report multiple errors if it finds them, given what it does. Any interest in submitting a PR?

And out of curiosity, what are you using Eliot for?

[tomprince]

Seems like it should always serialize all messages and just report multiple errors if it finds them, given what it does.

That seems sensible.

Any interest in submitting a PR?

I'm probably not going to do so soon, as I've worked around it locally, and am stuck on a python 2 version at the moment.

And out of curiosity, what are you using Eliot for?

I ran into this working on https://github.com/LeastAuthority/magic-folder

[itamarst]

Cool, I'm actually finishing up the port of Tahoe-LAFS to Python 3 at the moment.