Commit cc4cf10
chore(v1.100.1b.D2): GOTH docs/repo cleanup — closes the removal track (#503)
* chore(v1.100.1b.D2): cli/lib core — drop GOTH UI health checks + FHS entry
Removes the UI/auth health check + FHS spec entries that became orphan
after 1.100.1b.A retired the Web GUI surface.
cli/lib/nftban/core/nftban_health.sh:
- drop nftban_health_check_gui call site from main check loop
- drop matching export
- drop nftban-ui.service from optional_services[]
- drop /usr/lib/nftban/bin/nftban-ui + nftban-ui-auth from
optional_binaries[] (now empty array)
- drop nftban-ui from optional_bins[]
cli/lib/nftban/core/nftban_health_checks_integrations.sh:
- delete nftban_health_check_gui() function in full (199 lines)
The function inspected /usr/sbin/nftban-ui binary, GUI service
state, /run/nftban-ui auth socket dir, /run/nftban-ui/auth.sock,
nftban-ui-auth.service — every target deleted in earlier C2 work.
- drop matching export
- update header purpose comment (drop "gui" from list)
cli/lib/nftban/core/nftban_health_checks_security.sh:
- drop nftban-ui.service from systemd-analyze key_services list
cli/lib/nftban/core/nftban_fhs_spec.sh:
- drop /run/nftban-ui from NFTBAN_FHS_DIRECTORIES (was the auth
socket directory; no longer created by tmpfiles after C2 removed
the staging entry).
cli/lib/nftban/exporters/:
- delete nftban_exporter_gui_cache.sh in full — generated UI-only
cache files (traffic_history.json, dropped_by_country.json,
dropped_by_port.json) that the retired Web GUI consumed.
- drop the matching source + generate_gui_cache_files call from
nftban_unified_exporter_collect.sh (the only sourcing site).
Verified on lab2: go build ./... clean, go test ./internal/... all
pass with etc/ shipped, go mod tidy no-op, bash -n clean on all
edited shell files.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(v1.100.1b.D2): cli/lib JSON registries — drop UI surface entries
Removes registry entries that referenced the retired Web GUI surface.
cli/lib/nftban/data/fhs_directories.json:
- drop /run/nftban-ui directory entry (the GUI/API runtime socket
directory; no longer created by any installer/tmpfiles path).
cli/lib/nftban/data/config-schema.json:
- drop NFTBAN_UI_BIN property
- drop NFTBAN_AUTH_BIN property
- drop NFTBAN_SERVICE_UI property
cli/lib/nftban/data/reports-registry.json:
- drop the "api" channel entry (depended on nftban-ui.service for
its base_endpoint /api/v1/; no daemon serves this endpoint
anymore after the Web GUI retirement).
Verified: all 3 JSON files parse clean (json.load).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(v1.100.1b.D2): CI workflows — drop obsolete templ + libpam steps
After 1.100.1b.B/C1/C2 deleted all .templ files, _templ.go generated
files, msteinert/pam/v2 imports, and PAM-using packages, the
templ-install + libpam0g-dev apt-install steps in CI workflows are
pure dead steps.
Verified: zero .templ / _templ.go / "C" / msteinert/pam references
remain in tree (across cmd/, internal/, pkg/).
Removed steps:
- ci-go.yml: templ install/generate/verify + libpam0g-dev install
- build-packages.yml: templ install + libpam0g-dev install
- ci-smoke.yml: templ install/generate + libpam0g-dev (kept
nftables, jq)
- codeql.yml: templ install/generate + libpam0g-dev install
- secure-go.yml: templ install/generate + libpam0g-dev install
- osv-scanner.yml: libpam0g-dev install + matching comment
- project-health.yml: templ install/generate + libpam0g-dev (kept
shellcheck/shfmt/yamllint/jq/devscripts/nftables)
- release.yml: libpam0g-dev install + 2 decommission comments
- slsa-go-releaser.yml: 3 decommission comments
- ci-runtime-truth.yml: refresh templ-stub comments to reflect
CGO-required (not templ-required) reasoning
CGO build flags preserved (still required transitively by
nftban-core + nftband; verified by go build ./... on lab2).
Also: CHANGELOG entry under [Unreleased] documenting D as the closing
phase of the GOTH/UI removal track.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(v1.100.1b.D2): FHS YAML + tmpfiles — close the regenerator gap
CI Policy Gates fired on PR #503 because:
- build/fhs-spec.yaml is the source-of-truth that drives
build/generate-fhs-outputs.sh
- I had manually pre-edited the generated outputs (fhs_directories.json
and nftban_fhs_spec.sh) to drop /run/nftban-ui, but missed the YAML
source — so the regenerator was emitting the entry back.
- This commit removes /run/nftban-ui from the YAML and runs the
regenerator, which also drops the matching tmpfiles directive
(d /run/nftban-ui 0755 root nftban -).
Net mechanical fallout of 1.100.1b.D2 (parallel to the go mod tidy
convergence fixes on PRs #500 / #501).
After this commit, regenerator output matches committed state
(verified locally: ./build/generate-fhs-outputs.sh is a no-op).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 7a731be commit cc4cf10
22 files changed
Lines changed: 66 additions & 753 deletions
File tree
- .github/workflows
- build
- cli/lib/nftban
- core
- data
- exporters
- install/systemd/tmpfiles.d
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | 96 | | |
105 | 97 | | |
106 | 98 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | 14 | | |
19 | 15 | | |
20 | 16 | | |
| |||
43 | 39 | | |
44 | 40 | | |
45 | 41 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | 42 | | |
50 | 43 | | |
51 | 44 | | |
| |||
55 | 48 | | |
56 | 49 | | |
57 | 50 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | 51 | | |
72 | 52 | | |
73 | 53 | | |
| |||
103 | 83 | | |
104 | 84 | | |
105 | 85 | | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | 86 | | |
110 | 87 | | |
111 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
91 | | - | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
92 | 93 | | |
93 | 94 | | |
94 | | - | |
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
| 46 | + | |
53 | 47 | | |
54 | 48 | | |
55 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | 53 | | |
57 | 54 | | |
58 | 55 | | |
| |||
62 | 59 | | |
63 | 60 | | |
64 | 61 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | 62 | | |
72 | 63 | | |
73 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | 53 | | |
57 | 54 | | |
58 | 55 | | |
| |||
62 | 59 | | |
63 | 60 | | |
64 | 61 | | |
65 | | - | |
66 | 62 | | |
67 | 63 | | |
68 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | 51 | | |
58 | 52 | | |
59 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | 62 | | |
66 | 63 | | |
67 | 64 | | |
| |||
368 | 365 | | |
369 | 366 | | |
370 | 367 | | |
371 | | - | |
372 | 368 | | |
373 | 369 | | |
374 | 370 | | |
| |||
644 | 640 | | |
645 | 641 | | |
646 | 642 | | |
647 | | - | |
648 | 643 | | |
649 | 644 | | |
650 | 645 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | 57 | | |
61 | 58 | | |
62 | 59 | | |
| |||
66 | 63 | | |
67 | 64 | | |
68 | 65 | | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | 66 | | |
76 | 67 | | |
77 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | 18 | | |
24 | 19 | | |
25 | 20 | | |
| |||
93 | 88 | | |
94 | 89 | | |
95 | 90 | | |
96 | | - | |
97 | 91 | | |
98 | 92 | | |
99 | 93 | | |
| |||
116 | 110 | | |
117 | 111 | | |
118 | 112 | | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | 113 | | |
124 | 114 | | |
125 | 115 | | |
| |||
0 commit comments