chore: remove cloud specific onboarding

CMK-30426

Change-Id: Ibcc3f5a701d9a814c0e8b6ccb08380b97a799022

Author: hojjat-afsharan

cmk/gui/type_defs.py

@@ -323,7 +323,6 @@ class UserSpec(TypedDict, total=False):
     start_url: str | None
     two_factor_credentials: TwoFactorCredentials
     ui_sidebar_position: Literal["left"] | None
-    ui_saas_onboarding_button_toggle: Literal["invisible"] | None
     ui_theme: Literal["modern-dark", "facelift"] | None
     user_id: AnnotatedUserId
     user_scheme_serial: int

cmk/gui/userdb/store.py

@@ -201,7 +201,6 @@ def _load_users(lock: bool = False) -> Users:
                 "ui_theme",
                 "two_factor_credentials",
                 "ui_sidebar_position",
-                "ui_saas_onboarding_button_toggle",
                 "last_login",
             ],
             Callable,
@@ -216,7 +215,6 @@ def _load_users(lock: bool = False) -> Users:
         ("ui_theme", lambda x: x),
         ("two_factor_credentials", ast.literal_eval),
         ("ui_sidebar_position", lambda x: None if x == "None" else x),
-        ("ui_saas_onboarding_button_toggle", lambda x: None if x == "None" else x),
         ("last_login", ast.literal_eval),
     ]
 
@@ -520,15 +518,6 @@ def _save_user_profiles(
         else:
             remove_custom_attr(user_id, "ui_sidebar_position")
 
-        if "ui_saas_onboarding_button_toggle" in user:
-            save_custom_attr(
-                user_id,
-                "ui_saas_onboarding_button_toggle",
-                user["ui_saas_onboarding_button_toggle"],
-            )
-        else:
-            remove_custom_attr(user_id, "ui_saas_onboarding_button_toggle")
-
         _save_cached_profile(user_id, user, multisite_keys, non_contact_keys)
 
 
@@ -697,8 +686,7 @@ def _multisite_keys(user_attributes: Sequence[tuple[str, UserAttribute]]) -> lis
     multisite_variables = [
         var
         for var in _get_multisite_custom_variable_names(user_attributes)
-        if var
-        not in ("start_url", "ui_theme", "ui_sidebar_position", "ui_saas_onboarding_button_toggle")
+        if var not in ("start_url", "ui_theme", "ui_sidebar_position")
     ]
     return [
         "roles",

cmk/gui/userdb/userdata.py

@@ -132,7 +132,6 @@ class UserData:
     nav_hide_icons_title: Literal["hide"] | None | _MissingValueSentinel
     icons_per_item: Literal["entry"] | None | _MissingValueSentinel
     ui_sidebar_position: Literal["left"] | None  # I think None means right, which is the default?
-    ui_saas_onboarding_button_toggle: Literal["invisible"] | None
     ui_theme: Literal["modern-dark", "facelift"] | None
     # contextual_help_icon: NotRequired[Literal["hide_icon"] | None]
 
@@ -185,7 +184,6 @@ def to_userspec(self) -> UserSpec:
             ("last_login", self.last_login),
             # UI
             ("temperature_unit", self.temperature_unit),
-            ("ui_saas_onboarding_button_toggle", self.ui_saas_onboarding_button_toggle),
             ("ui_sidebar_position", self.ui_sidebar_position),
             ("ui_theme", self.ui_theme),
             ("start_url", self.start_url),
@@ -289,7 +287,6 @@ def from_userspec(
             temperature_unit=userspec.get("temperature_unit"),
             two_factor_credentials=userspec.get("two_factor_credentials"),
             ui_sidebar_position=userspec.get("ui_sidebar_position"),
-            ui_saas_onboarding_button_toggle=userspec.get("ui_saas_onboarding_button_toggle"),
             ui_theme=userspec.get("ui_theme"),
             created_on_version=userspec.get("created_on_version"),
             user_id=user_id,

tests/testlib/web_session.py

@@ -125,20 +125,13 @@ def _check_html_page_resources(self, url: str | bytes | None, soup: BeautifulSou
 
         # There might be other resources like iframe, audio, ... but we don't care about them
         self._check_resources(soup, base_url, "img", "src", ["image/png", "image/svg+xml"])
-        # Checkmk Cloud includes a new onboarding feature. This is loaded from an external source hosted
-        # by checkmk. We do not want to check it in the integration tests
-        script_filters = (
-            [("src", "https://static.saas-dev.cloudsandbox.checkmk.cloud")]
-            if edition_from_env().is_cloud_edition()
-            else None
-        )
         self._check_resources(
             soup,
             base_url,
             "script",
             "src",
             ["application/javascript", "text/javascript"],
-            filters=script_filters,
+            filters=None,
         )
         self._check_resources(
             soup, base_url, "link", "href", ["text/css"], filters=[("rel", "stylesheet")]

tests/unit/cmk/gui/test_pages.py

@@ -239,7 +239,6 @@ def test_registered_pages() -> None:
 
     if cmk_version.edition(paths.omd_root) is cmk_version.Edition.CLOUD:
         expected_pages += [
-            "ajax_saas_onboarding_button_toggle",
             "noauth:cognito_sso",
             "noauth:cognito_callback",
             "cognito_logout",