s3: listen on 0.0.0.0 + fixes to tests (#257)

Author: shcheklein

.github/workflows/release.yml

@@ -21,10 +21,10 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Set up Python 3.12
+      - name: Set up Python 3.14
         uses: actions/setup-python@v6
         with:
-          python-version: '3.12'
+          python-version: '3.14'
 
       - name: Upgrade pip and nox
         run: |

.github/workflows/tests.yml

@@ -23,9 +23,9 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        pyv: ["3.9", "3.10", "3.11", "3.12", "3.13"]
+        pyv: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
         include:
-          - {os: ubuntu-latest, pyv: "pypy3.10"}
+          - {os: ubuntu-latest, pyv: "pypy3.11"}
 
     steps:
       - name: Check out the repository
@@ -45,7 +45,7 @@ jobs:
           nox --version
 
       - name: Lint code
-        if: matrix.pyv != 'pypy3.10'
+        if: ${{ !startsWith(matrix.pyv, 'pypy') }}
         run: nox -s lint
 
       # https://github.com/iterative/pytest-servers/pull/122

noxfile.py

@@ -11,7 +11,7 @@
 
 
 @nox.session(
-    python=["3.9", "3.10", "3.11", "3.12", "3.13", "pypy3.10"],
+    python=["3.9", "3.10", "3.11", "3.12", "3.13", "3.14", "pypy3.11"],
 )
 def tests(session: nox.Session) -> None:
     session.install(".[dev]")

pyproject.toml

@@ -140,9 +140,7 @@ ignore = [
   "D105",  # missing docstring in magic method
   "D107",  # missing docstring in method
   "ANN002",  # missing type annotation
-  "ANN101",  # missing type annotation
   "ANN204",  # missing return type annotation
-  "PT004",  # pytest-missing-fixture-name-underscore
   "PLC0415"  # top level imports
 ]
 select = ["ALL"]

src/pytest_servers/fixtures.py

@@ -47,7 +47,7 @@ def tmp_local_path(
 ) -> UPath:
     """Return a temporary path."""
     ret = tmp_upath_factory.mktemp()
-    monkeypatch.chdir(ret)
+    monkeypatch.chdir(str(ret))
     return ret
 
 

src/pytest_servers/s3.py

@@ -17,7 +17,13 @@ def __init__(
 
     @property
     def endpoint_url(self) -> str:
-        return f"http://{self.ip_address}:{self.port}"
+        # `0.0.0.0`/`::` are wildcard bind addresses: valid for listening, but not a
+        # stable client destination. When users bind moto to all interfaces (common
+        # on Linux CI), advertise localhost so the test process can connect.
+        host = self.ip_address
+        if host in {"0.0.0.0", "::", "::0"}:  # noqa: S104
+            host = "127.0.0.1"
+        return f"http://{host}:{self.port}"
 
     @property
     def port(self) -> int:

tests/conftest.py

@@ -0,0 +1,60 @@
+import platform
+
+import pytest
+
+
+@pytest.fixture(autouse=True)
+def _disable_adlfs_memoryview_optimization_on_pypy(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    if platform.python_implementation() != "PyPy":
+        return
+
+    # Remove this whole fixture when either:
+    # - PyPy exposes an iterable `memoryview` compatible with Azure SDK request-body
+    #   checks, or
+    # - adlfs updates its own support check / stops using `memoryview` for uploads.
+    #
+    # This is intentionally a hard failure: it forces us to re-evaluate whether this
+    # workaround is still needed.
+    if hasattr(memoryview(b""), "__iter__"):
+        pytest.fail(
+            (
+                "PyPy memoryview now appears iterable; the adlfs/Azure workaround in "
+                "tests/conftest.py is likely obsolete and should be removed."
+            ),
+        )
+
+    try:
+        import adlfs.spec
+    except Exception:  # noqa: BLE001
+        return
+
+    azure_blob_file = getattr(adlfs.spec, "AzureBlobFile", None)
+    if azure_blob_file is None:
+        return
+
+    # If adlfs itself no longer claims memoryview support, then this workaround should
+    # be unnecessary and must be removed.
+    try:
+        if not azure_blob_file._sdk_supports_memoryview_for_writes(None):  # noqa: SLF001
+            pytest.fail(
+                (
+                    "adlfs no longer reports memoryview support for writes; the PyPy "
+                    "workaround in tests/conftest.py should be removed."
+                ),
+            )
+    except Exception:  # noqa: BLE001
+        # If this API shape changes, we also want a visible signal rather than
+        # silently masking.
+        pytest.fail(
+            "adlfs AzureBlobFile._sdk_supports_memoryview_for_writes API changed; "
+            "re-evaluate/remove the PyPy workaround in tests/conftest.py.",
+        )
+
+    monkeypatch.setattr(
+        azure_blob_file,
+        "_sdk_supports_memoryview_for_writes",
+        lambda *_args, **_kwargs: False,
+        raising=False,
+    )

tests/test_s3_endpoint_url.py

@@ -0,0 +1,10 @@
+import pytest
+
+
+@pytest.fixture(scope="session")
+def s3_server_config() -> dict:
+    return {"ip_address": "0.0.0.0"}
+
+
+def test_s3_endpoint_url_is_localhost_when_bound_to_wildcard(s3_server):
+    assert s3_server["endpoint_url"].startswith("http://127.0.0.1:")