Skip to content

Commit 2f07eff

Browse files
authored
fix: fix ios old arch (#37)
1 parent 8bb29f1 commit 2f07eff

File tree

2 files changed

+21
-28
lines changed

2 files changed

+21
-28
lines changed

example/ios/Podfile.lock

+6-28
Original file line numberDiff line numberDiff line change
@@ -1210,7 +1210,7 @@ PODS:
12101210
- React-jsiexecutor
12111211
- React-RCTFBReactNativeSpec
12121212
- ReactCommon/turbomodule/core
1213-
- react-native-audio-playback (1.0.6):
1213+
- react-native-audio-playback (1.1.1):
12141214
- DoubleConversion
12151215
- glog
12161216
- hermes-engine
@@ -1232,28 +1232,6 @@ PODS:
12321232
- ReactCommon/turbomodule/core
12331233
- Yoga
12341234
- react-native-slider (4.5.5):
1235-
- DoubleConversion
1236-
- glog
1237-
- hermes-engine
1238-
- RCT-Folly (= 2024.11.18.00)
1239-
- RCTRequired
1240-
- RCTTypeSafety
1241-
- React-Core
1242-
- React-debug
1243-
- React-Fabric
1244-
- React-featureflags
1245-
- React-graphics
1246-
- React-ImageManager
1247-
- react-native-slider/common (= 4.5.5)
1248-
- React-NativeModulesApple
1249-
- React-RCTFabric
1250-
- React-rendererdebug
1251-
- React-utils
1252-
- ReactCodegen
1253-
- ReactCommon/turbomodule/bridging
1254-
- ReactCommon/turbomodule/core
1255-
- Yoga
1256-
- react-native-slider/common (4.5.5):
12571235
- DoubleConversion
12581236
- glog
12591237
- hermes-engine
@@ -1818,18 +1796,18 @@ SPEC CHECKSUMS:
18181796
React-logger: e7eeebaed32b88dcc29b10901aa8c5822dc397c4
18191797
React-Mapbuffer: 73dd1210c4ecf0dfb4e2d4e06f2a13f824a801a9
18201798
React-microtasksnativemodule: d03753688e2abf135edcd4160ab3ce7526da8b0d
1821-
react-native-audio-playback: e3b40982c3b6dff7dc0ed0680d7481d43a8f54dc
1822-
react-native-slider: 54e7f67e9e4c92c0edac77bbf58abfaf1f60055f
1799+
react-native-audio-playback: 6446cd5b6894cd4830f29e58e44f6afe3dd94231
1800+
react-native-slider: fbd5138b5386e36807d0e0666135b0c2c32ba4fe
18231801
React-nativeconfig: cb207ebba7cafce30657c7ad9f1587a8f32e4564
18241802
React-NativeModulesApple: 8411d548b1ad9d2b3e597beb9348e715c8020e0c
18251803
React-perflogger: c4c3b7c18f8a50cdbe2bcdd2f15705ba029a5a02
18261804
React-performancetimeline: 38bda258bd9f9da19b27615e8edfbec064aa42cc
18271805
React-RCTActionSheet: 0fdf55fb8724856d63ca8c63cdb4e2325e15e8ec
18281806
React-RCTAnimation: b2fcc7c462f1fb5e195a5547f6e405ec9a60d80f
1829-
React-RCTAppDelegate: d5aed095faa6fd0b0aff3c98d0b078680890cde2
1807+
React-RCTAppDelegate: 3c39a96f93177b5068fe62df70e914357a154e4c
18301808
React-RCTBlob: 3b5441953e3dcc4aaee8f539b17d9c54b7a4b111
1831-
React-RCTFabric: 022ff67d55ac5833b984085628e15af113cd9b52
1832-
React-RCTFBReactNativeSpec: 536442edc77efaec464c3c805c1e44fd811639d3
1809+
React-RCTFabric: 839023450cf399ff5c78b416d056a455197e92cc
1810+
React-RCTFBReactNativeSpec: 0a968706c6714eb448162dd06b29b8203020f3fc
18331811
React-RCTImage: f189ae651e3c97879b4cdefcba1d4cffe55439da
18341812
React-RCTLinking: 759ac5e4aed95ac3c29849f98ff3f3b5ece830ed
18351813
React-RCTNetwork: ce1f38434a70eb1e228344f7632e636c3ceca03b

ios/AudioPlayback.mm

+15
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ - (instancetype) init {
2020

2121
RCT_EXPORT_MODULE()
2222

23+
// Remove the old arch implementation when deprecating old arch
24+
#ifdef RCT_NEW_ARCH_ENABLED
2325
RCT_EXPORT_SYNCHRONOUS_TYPED_METHOD(NSDictionary *, setupAudioStream:(JS::NativeAudioPlayback::SpecSetupAudioStreamOptions &)options) {
2426
double sampleRate = options.sampleRate();
2527
double channelCount = options.channelCount();
@@ -30,6 +32,19 @@ - (instancetype) init {
3032

3133
return @{@"error":error?: [NSNull null]};
3234
}
35+
#else
36+
RCT_EXPORT_SYNCHRONOUS_TYPED_METHOD(NSDictionary *, setupAudioStream:(NSDictionary *)options) {
37+
double sampleRate = [options[@"sampleRate"] doubleValue];
38+
double channelCount = [options[@"channelCount"] doubleValue];
39+
double audioSessionCategory = [options[@"ios"][@"audioSessionCategory"] doubleValue];
40+
41+
42+
NSString *error = [moduleImpl setupAudioStreamWithSampleRate:sampleRate channelCount:channelCount audioSessionCategory: audioSessionCategory];
43+
44+
return @{@"error":error?: [NSNull null]};
45+
}
46+
#endif
47+
3348

3449
RCT_EXPORT_SYNCHRONOUS_TYPED_METHOD(NSDictionary *, openAudioStream) {
3550
NSString *error = [moduleImpl openAudioStream];

0 commit comments

Comments
 (0)