Skip to content

Commit a06a294

Browse files
committed
Test for kindOf value for float64 and bool, resorb envBoolMap
1 parent d0cdf7d commit a06a294

File tree

2 files changed

+15
-22
lines changed

2 files changed

+15
-22
lines changed

charts/minecraft/templates/_helpers.tpl

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,7 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
2626
{{- end -}}
2727

2828
{{- define "minecraft.envMap" }}
29-
{{- if index . 1 }}
30-
- name: {{ index . 0 }}
31-
value: {{ index . 1 | quote }}
32-
{{- end }}
33-
{{- end }}
34-
35-
{{- define "minecraft.envBoolMap" }}
36-
{{- if ne (toString (index . 1)) "default" }}
29+
{{- if or (index . 1) (kindIs "float64" (index . 1)) (kindIs "bool" (index . 1)) }}
3730
- name: {{ index . 0 }}
3831
value: {{ index . 1 | quote }}
3932
{{- end }}

charts/minecraft/templates/deployment.yaml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ spec:
144144
{{- end }}
145145
{{- else if eq .Values.minecraftServer.type "CURSEFORGE" }}
146146
{{- template "minecraft.envMap" list "CF_SERVER_MOD" .Values.minecraftServer.cfServerMod }}
147-
{{- template "minecraft.envBoolMap" list "FTB_LEGACYJAVAFIXER" .Values.minecraftServer.ftbLegacyJavaFixer }}
147+
{{- template "minecraft.envMap" list "FTB_LEGACYJAVAFIXER" .Values.minecraftServer.ftbLegacyJavaFixer }}
148148
{{- end }}
149149
{{- template "minecraft.envMap" list "VERSION" .Values.minecraftServer.version }}
150150
{{- template "minecraft.envMap" list "DIFFICULTY" .Values.minecraftServer.difficulty }}
@@ -153,27 +153,27 @@ spec:
153153
{{- template "minecraft.envMap" list "ICON" .Values.minecraftServer.icon }}
154154
{{- template "minecraft.envMap" list "MAX_PLAYERS" .Values.minecraftServer.maxPlayers }}
155155
{{- template "minecraft.envMap" list "MAX_WORLD_SIZE" .Values.minecraftServer.maxWorldSize }}
156-
{{- template "minecraft.envBoolMap" list "ALLOW_NETHER" .Values.minecraftServer.allowNether }}
157-
{{- template "minecraft.envBoolMap" list "ANNOUNCE_PLAYER_ACHIEVEMENTS" .Values.minecraftServer.announcePlayerAchievements }}
158-
{{- template "minecraft.envBoolMap" list "ENABLE_COMMAND_BLOCK" .Values.minecraftServer.enableCommandBlock }}
159-
{{- template "minecraft.envBoolMap" list "FORCE_GAMEMODE" .Values.minecraftServer.forcegameMode }}
156+
{{- template "minecraft.envMap" list "ALLOW_NETHER" .Values.minecraftServer.allowNether }}
157+
{{- template "minecraft.envMap" list "ANNOUNCE_PLAYER_ACHIEVEMENTS" .Values.minecraftServer.announcePlayerAchievements }}
158+
{{- template "minecraft.envMap" list "ENABLE_COMMAND_BLOCK" .Values.minecraftServer.enableCommandBlock }}
159+
{{- template "minecraft.envMap" list "FORCE_GAMEMODE" .Values.minecraftServer.forcegameMode }}
160160
{{- if .Values.minecraftServer.forceReDownload }}
161161
- name: FORCE_REDOWNLOAD
162162
value: "TRUE"
163163
{{- end }}
164-
{{- template "minecraft.envBoolMap" list "GENERATE_STRUCTURES" .Values.minecraftServer.generateStructures }}
165-
{{- template "minecraft.envBoolMap" list "HARDCORE" .Values.minecraftServer.hardcore }}
164+
{{- template "minecraft.envMap" list "GENERATE_STRUCTURES" .Values.minecraftServer.generateStructures }}
165+
{{- template "minecraft.envMap" list "HARDCORE" .Values.minecraftServer.hardcore }}
166166
{{- template "minecraft.envMap" list "MAX_BUILD_HEIGHT" .Values.minecraftServer.maxBuildHeight }}
167167
{{- template "minecraft.envMap" list "MAX_TICK_TIME" .Values.minecraftServer.maxTickTime }}
168-
{{- template "minecraft.envBoolMap" list "SPAWN_ANIMALS" .Values.minecraftServer.spawnAnimals }}
169-
{{- template "minecraft.envBoolMap" list "SPAWN_MONSTERS" .Values.minecraftServer.spawnMonsters }}
170-
{{- template "minecraft.envBoolMap" list "SPAWN_NPCS" .Values.minecraftServer.spawnNPCs }}
168+
{{- template "minecraft.envMap" list "SPAWN_ANIMALS" .Values.minecraftServer.spawnAnimals }}
169+
{{- template "minecraft.envMap" list "SPAWN_MONSTERS" .Values.minecraftServer.spawnMonsters }}
170+
{{- template "minecraft.envMap" list "SPAWN_NPCS" .Values.minecraftServer.spawnNPCs }}
171171
{{- template "minecraft.envMap" list "SPAWN_PROTECTION" .Values.minecraftServer.spawnProtection }}
172172
{{- template "minecraft.envMap" list "VIEW_DISTANCE" .Values.minecraftServer.viewDistance }}
173173
{{- template "minecraft.envMap" list "SEED" .Values.minecraftServer.levelSeed }}
174174
{{- template "minecraft.envMap" list "MODE" .Values.minecraftServer.gameMode }}
175175
{{- template "minecraft.envMap" list "MOTD" .Values.minecraftServer.motd }}
176-
{{- template "minecraft.envBoolMap" list "PVP" .Values.minecraftServer.pvp }}
176+
{{- template "minecraft.envMap" list "PVP" .Values.minecraftServer.pvp }}
177177
{{- template "minecraft.envMap" list "LEVEL_TYPE" .Values.minecraftServer.levelType }}
178178
{{- template "minecraft.envMap" list "GENERATOR_SETTINGS" .Values.minecraftServer.generatorSettings }}
179179
{{- template "minecraft.envMap" list "LEVEL" .Values.minecraftServer.worldSaveName }}
@@ -221,12 +221,12 @@ spec:
221221
- name: RESOURCE_PACK_ENFORCE
222222
value: "TRUE"
223223
{{- end }}
224-
{{- template "minecraft.envBoolMap" list "ONLINE_MODE" .Values.minecraftServer.onlineMode }}
225-
{{- template "minecraft.envBoolMap" list "ENFORCE_SECURE_PROFILE" .Values.minecraftServer.enforceSecureProfile }}
224+
{{- template "minecraft.envMap" list "ONLINE_MODE" .Values.minecraftServer.onlineMode }}
225+
{{- template "minecraft.envMap" list "ENFORCE_SECURE_PROFILE" .Values.minecraftServer.enforceSecureProfile }}
226226
{{- template "minecraft.envMap" list "MEMORY" .Values.minecraftServer.memory }}
227227
{{- template "minecraft.envMap" list "JVM_OPTS" .Values.minecraftServer.jvmOpts }}
228228
{{- template "minecraft.envMap" list "JVM_XX_OPTS" .Values.minecraftServer.jvmXXOpts }}
229-
{{- template "minecraft.envBoolMap" list "OVERRIDE_SERVER_PROPERTIES" .Values.minecraftServer.overrideServerProperties }}
229+
{{- template "minecraft.envMap" list "OVERRIDE_SERVER_PROPERTIES" .Values.minecraftServer.overrideServerProperties }}
230230

231231
{{- if .Values.minecraftServer.rcon.enabled }}
232232
- name: ENABLE_RCON

0 commit comments

Comments
 (0)