minecraft: unused deprecated serviceAnnotations property

[emyfops]

The minecraftServer.serviceAnnotations field present at

minecraft-server-charts/charts/minecraft/values.yaml

Lines 257 to 258 in 197dcf3

	# DEPRECATED: use top-level rconServiceAnnotations instead
	serviceAnnotations: {}

is not being used

We can confuse it with the real serviceAnnotations field present in the root level, thus applying no annotations to the service

minecraft-server-charts/charts/minecraft/values.yaml

Line 428 in 197dcf3

serviceAnnotations: {}

used at

minecraft-server-charts/charts/minecraft-bedrock/templates/minecraft-svc.yaml

Lines 13 to 17 in 197dcf3

	{{- if .Values.serviceAnnotations }}
	annotations:
	{{- range $key, $value := .Values.serviceAnnotations }}
	{{ $key }}: {{ $value | quote }}
	{{- end }}

As of 2024-08-06, the minecraftServer.serviceAnnotations is not used, which means that we can safely remove it

Because it's not worth creating a new release simply to remove a deprecated field, someone can reference this issue in the next release pull request to remove it