Move if CONFIG.statistics_enabled into the handler for the /metrics route

Author: Mateusz Bączek

src/invidious/routes/api/v1/misc.cr

@@ -29,6 +29,11 @@ module Invidious::Routes::API::V1::Misc
   end
 
   def self.metrics(env)
+    if !CONFIG.statistics_enabled
+      env.response.status_code = 204
+      return
+    end
+
     env.response.content_type = "text/plain"
 
     return String.build do |str|

src/invidious/routing.cr

@@ -310,13 +310,7 @@ module Invidious::Routing
 
       # Misc
       get "/api/v1/stats", {{namespace}}::Misc, :stats
-      if CONFIG.statistics_enabled
-        get "/api/v1/metrics", {{namespace}}::Misc, :metrics
-      else
-        get "/api/v1/metrics" do |env|
-          env.response.status_code = 204
-        end
-      end
+      get "/api/v1/metrics", {{namespace}}::Misc, :metrics
       get "/api/v1/playlists/:plid", {{namespace}}::Misc, :get_playlist
       get "/api/v1/auth/playlists/:plid", {{namespace}}::Misc, :get_playlist
       get "/api/v1/mixes/:rdid", {{namespace}}::Misc, :mixes