refactor: extract BaseObjectLike and similar into a separate 'core' module (#28870)

Sam-Armstrong · web-flow · commit 35f030d47fc2 · 2025-06-12T04:11:13.000+01:00
diff --git a/ivy/transpiler/ast/source_gen.py b/ivy/transpiler/ast/source_gen.py
@@ -1,27 +1,26 @@
 import gast
 import os
+from packaging.version import parse
 import textwrap
 from typing import Union, List, Dict, Set, Tuple, Optional, TYPE_CHECKING
-from packaging.version import parse
 
 import ivy.transpiler.ast.globals as glob
 from .globals import (
-    TRANSLATED_OUTPUTS_SUBDIR,
-    MONKEY_PATCH_GLOBALS,
-    MODULE_TO_ALIAS,
-    TranslatedContext,
-    FRONTEND_STANDARD_GLOBALS_TARGET_TO_MODULE,
     BACKEND_STANDARD_GLOBALS,
+    FRONTEND_STANDARD_GLOBALS_TARGET_TO_MODULE,
     IVY_STANDARD_GLOBALS_TARGET_TO_MODULE,
+    MODULE_TO_ALIAS,
+    MONKEY_PATCH_GLOBALS,
+    TranslatedContext,
+    TRANSLATED_OUTPUTS_SUBDIR,
 )
 from .analysis import get_translated_nodes
-from .nodes import FromImportObj, ImportObj, InternalObj
+from .nodes import FromImportObj, ImportObj
 
-from ..translations.data.object_like import BaseObjectLike
+from ivy.transpiler.core.object_like import BaseObjectLike
 from ivy.transpiler.utils.api_utils import (
     get_native_module_str_from_backend,
     SUPPORTED_BACKENDS_PREFIX,
-    TRANSLATED_OBJ_PREFIX,
 )
 from ivy.transpiler.utils.ast_utils import ast_to_source_code, check_syntax
 from ivy.transpiler.utils.cache_utils import (
@@ -34,10 +33,10 @@
 from ivy.transpiler.utils.type_utils import Types
 
 if TYPE_CHECKING:
-    from ivy.transpiler.translations.data.global_like import (
+    from ivy.transpiler.core.global_like import (
         GlobalObjectLike,
     )
-    from ivy.transpiler.translations.data.object_like import (
+    from ivy.transpiler.core.object_like import (
         TypeObjectLike,
         FuncObjectLike,
     )
diff --git a/ivy/transpiler/core/__init__.py b/ivy/transpiler/core/__init__.py
@@ -0,0 +1,11 @@
+from .global_like import GlobalObjectLike, Position, StackObjectLike
+from .object_like import BaseObjectLike, FuncObjectLike, TypeObjectLike
+
+__all__ = [
+    "BaseObjectLike",
+    "FuncObjectLike",
+    "GlobalObjectLike",
+    "Position",
+    "StackObjectLike",
+    "TypeObjectLike",
+]
diff --git a/ivy/transpiler/core/global_like.py b/ivy/transpiler/core/global_like.py
@@ -1,15 +1,14 @@
 """Main file to hold DTOs to represent globals captured during transformations."""
 
-# global
 from __future__ import annotations
-from typing import Dict
-import gast
 from enum import Enum
+import gast
+from typing import Dict
+
+from ivy.transpiler.ast.globals import TranslatedContext
+from ivy.transpiler.utils.ast_utils import ast_to_source_code
 
-# local
-from ...translations.data.object_like import BaseObjectLike
-from ...ast.globals import TranslatedContext
-from ...utils.ast_utils import ast_to_source_code
+from .object_like import BaseObjectLike
 
 
 class Position(Enum):
diff --git a/ivy/transpiler/core/object_like.py b/ivy/transpiler/core/object_like.py
@@ -1,44 +1,42 @@
 """Main file to hold DTOs for object likes."""
 
-# global
 from __future__ import annotations
-import ivy
 import dill
 import inspect
+import ivy
 from types import FunctionType, MethodType, ModuleType
 from typing import Dict, Optional, Union, TYPE_CHECKING
 
-# local
-from ...utils.api_utils import (
-    TRANSLATED_OBJ_SUFFIX,
-    is_mixed_function,
-    maybe_get_methods,
-    maybe_get_properties,
-    maybe_get_frontend_base_methods,
-    maybe_get_frontend_base_module_source,
+from ivy.transpiler import globals as glob
+from ivy.transpiler.exceptions.exceptions import (
+    ProhibitedObjectAccessError,
+    InvalidObjectException,
+)
+from ivy.transpiler.utils.api_utils import (
+    from_conv_block,
     is_backend_api,
     is_frontend_api,
-    is_ivy_api,
-    is_translated_api,
-    is_hf_pretrained_class,
     is_helper_func,
+    is_hf_pretrained_class,
+    is_ivy_api,
+    is_mixed_function,
     is_submodule_of,
-    from_conv_block,
+    is_translated_api,
+    maybe_get_frontend_base_methods,
+    maybe_get_frontend_base_module_source,
+    maybe_get_methods,
+    maybe_get_properties,
+    TRANSLATED_OBJ_SUFFIX,
 )
-from ...utils.inspect_utils import (
+from ivy.transpiler.utils.inspect_utils import (
     get_closure_vars,
     object_to_source_code,
 )
-from ...utils import pickling_utils
-from ...utils.type_utils import Types
-from ...exceptions.exceptions import (
-    ProhibitedObjectAccessError,
-    InvalidObjectException,
-)
-from ivy.transpiler import globals as glob
+from ivy.transpiler.utils import pickling_utils
+from ivy.transpiler.utils.type_utils import Types
 
 if TYPE_CHECKING:
-    from ...utils.ast_utils import TranslatedContext
+    from ivy.transpiler.ast.globals import TranslatedContext
 
 
 class BaseObjectLike:
@@ -301,7 +299,7 @@ def _derive_qualname(self):
         return getattr(self._get_obj(), "__qualname__", "")
 
     def _derive_module(self):
-        from ...ast.source_gen import FileNameStrategy
+        from ..ast.source_gen import FileNameStrategy
 
         obj_mod = inspect.getmodule(self._get_obj())
         if obj_mod:
@@ -538,7 +536,7 @@ def from_object(
 
         obj_type = Types.get_type(obj)
 
-        from ...ast.source_gen import FileNameStrategy
+        from ..ast.source_gen import FileNameStrategy
 
         ObjectLike = BaseObjectLike._infer_object_like(obj_type)
         object_like = ObjectLike(
diff --git a/ivy/transpiler/main_config.py b/ivy/transpiler/main_config.py
@@ -15,4 +15,4 @@
 
 # Frameworks whose code S2S supports currently
 SUPPORTED_S2S_SOURCES = ["torch", "ivy"]
-SUPPORTED_S2S_TARGETS = ["tensorflow", "jax", "numpy", "ivy"]
+SUPPORTED_S2S_TARGETS = ["tensorflow", "jax", "numpy", "ivy", "torch"]
diff --git a/ivy/transpiler/transformations/transformer.py b/ivy/transpiler/transformations/transformer.py
@@ -15,7 +15,7 @@
 from ..transformations.transformers.base_transformer import (
     BaseTransformer,
 )
-from ..translations.data.object_like import (
+from ..core.object_like import (
     BaseObjectLike,
 )
 from ..transformations.transformers.rename_transformer import (
@@ -29,10 +29,10 @@
     from ..transformations.transformers.globals_transformer.base_transformer import (
         GlobalObj,
     )
-    from ..translations.data.object_like import (
+    from ..core.object_like import (
         TypeObjectLike,
     )
-    from ..translations.data.object_like import (
+    from ..core.object_like import (
         FuncObjectLike,
     )
     from ..utils.ast_utils import ImportObj, FromImportObj
diff --git a/ivy/transpiler/transformations/transformers/globals_transformer/base_transformer.py b/ivy/transpiler/transformations/transformers/globals_transformer/base_transformer.py
@@ -9,12 +9,12 @@
     BaseTransformer,
 )
 from ...transformer import Transformer
-from ....translations.data.global_like import (
+from ....core.global_like import (
     GlobalObjectLike,
     Position,
     StackObjectLike,
 )
-from ....translations.data.object_like import BaseObjectLike
+from ....core.object_like import BaseObjectLike
 from ....ast.analysis import get_function_vars, get_module_globals
 from ....ast.visitors import get_global_assignment
 from ....ast.globals import (
@@ -45,7 +45,7 @@
 )
 
 if TYPE_CHECKING:
-    from ....translations.data.object_like import (
+    from ....core.object_like import (
         TypeObjectLike,
         FuncObjectLike,
     )
diff --git a/ivy/transpiler/transformations/transformers/recursive_transformer/base_transformer.py b/ivy/transpiler/transformations/transformers/recursive_transformer/base_transformer.py
@@ -199,7 +199,7 @@ def _recursively_translate(self, obj_name: str, obj_to_translate, node=None):
         from_global, parent = self.preprocess_origin_info(obj_to_translate, new_name)
 
         # 3 Recursively transform the function
-        from ivy.transpiler.translations.data.object_like import (
+        from ivy.transpiler.core.object_like import (
             BaseObjectLike,
         )
 
@@ -401,7 +401,7 @@ def visit_ClassDef(self, node):
             from_global, parent = self.preprocess_origin_info(base, base_new_name)
 
             # 3 Recursively transform the function
-            from ivy.transpiler.translations.data.object_like import (
+            from ivy.transpiler.core.object_like import (
                 BaseObjectLike,
             )
 
diff --git a/ivy/transpiler/translations/data/__init__.py b/ivy/transpiler/translations/data/__init__.py
diff --git a/ivy/transpiler/translations/helpers.py b/ivy/transpiler/translations/helpers.py
@@ -10,7 +10,7 @@
 from types import FunctionType
 
 from ivy.transpiler.ast.source_gen import FileNameStrategy
-from ivy.transpiler.translations.data.object_like import BaseObjectLike
+from ivy.transpiler.core.object_like import BaseObjectLike
 from ivy.transpiler.utils.naming_utils import NAME_GENERATOR
 from ivy.transpiler.utils.source_utils import (
     get_new_output_dir_name,
@@ -20,7 +20,7 @@
 )
 
 if TYPE_CHECKING:
-    from ivy.transpiler.translations.data.object_like import (
+    from ivy.transpiler.core.object_like import (
         FuncObjectLike,
         TypeObjectLike,
     )
diff --git a/ivy/transpiler/translations/translator.py b/ivy/transpiler/translations/translator.py
@@ -25,7 +25,7 @@
 from ..utils.naming_utils import NAME_GENERATOR
 from ..utils import api_utils
 from ..utils.api_utils import get_function_from_modules
-from ..translations.data.object_like import (
+from ..core.object_like import (
     BaseObjectLike,
     TypeObjectLike,
     FuncObjectLike,
diff --git a/ivy/transpiler/utils/api_utils.py b/ivy/transpiler/utils/api_utils.py
@@ -180,7 +180,7 @@ def is_builtin_method(method, to_ignore=()):
 
 
 def is_method_of_class(method_name, cls, to_ignore=()):
-    from ivy.transpiler.translations.data.object_like import BaseObjectLike
+    from ivy.transpiler.core.object_like import BaseObjectLike
 
     if isinstance(cls, BaseObjectLike):
         return method_name in cls.methods
@@ -195,7 +195,7 @@ def is_method_of_class(method_name, cls, to_ignore=()):
 
 
 def is_property(method_name, cls, to_ignore=()):
-    from ivy.transpiler.translations.data.object_like import BaseObjectLike
+    from ivy.transpiler.core.object_like import BaseObjectLike
 
     if isinstance(cls, BaseObjectLike):
         return method_name in cls.properties
diff --git a/ivy/transpiler/utils/cache_utils.py b/ivy/transpiler/utils/cache_utils.py
@@ -18,13 +18,13 @@
 from . import pickling_utils
 
 if TYPE_CHECKING:
-    from ..translations.data.object_like import (
+    from ..core.object_like import (
         BaseObjectLike,
     )
-    from ..translations.data.global_like import (
+    from ..core.global_like import (
         GlobalObjectLike,
     )
-    from .ast_utils import FromImportObj, ImportObj
+    from ..ast.nodes import FromImportObj, ImportObj
 
 """
 Asyncio Helpers
diff --git a/ivy/transpiler/utils/decorator_utils.py b/ivy/transpiler/utils/decorator_utils.py
@@ -11,7 +11,6 @@
     handle_transpose_in_pad,
     store_config_info,
 )
-from ..translations.data.object_like import BaseObjectLike
 from .type_utils import Types
 
 
diff --git a/ivy/transpiler/utils/naming_utils.py b/ivy/transpiler/utils/naming_utils.py
@@ -80,7 +80,7 @@ def set_prefixes(self, target):
 
     def get_suffix(self, obj: Optional[Any]) -> str:
         """Get the suffix for the candidate name based on the object's module."""
-        from ivy.transpiler.translations.data.object_like import (
+        from ivy.transpiler.core.object_like import (
             BaseObjectLike,
         )
 
@@ -101,7 +101,7 @@ def get_suffix(self, obj: Optional[Any]) -> str:
 
     def get_candidate_name(self, obj: Optional[Any]):
         """Generate a candidate name for an object."""
-        from ivy.transpiler.translations.data.object_like import (
+        from ivy.transpiler.core.object_like import (
             BaseObjectLike,
         )
 
diff --git a/ivy/transpiler/utils/pickling_utils.py b/ivy/transpiler/utils/pickling_utils.py
@@ -19,7 +19,7 @@ def get_object_hash(obj):
     """
     Generate a hash for a given object, object-like, function, method, class or builtins.
     """
-    from ..translations.data.object_like import BaseObjectLike
+    from ..core.object_like import BaseObjectLike
     from .cache_utils import AtomicCacheUnit
 
     # If the object is a BaseObjectLike, use its hash method
@@ -101,10 +101,10 @@ def deserialize_acu(unit):
         """
         Deserialize the object-like properties of a unit, including object-like and global-object-like.
         """
-        from ivy.transpiler.translations.data.object_like import (
+        from ivy.transpiler.core.object_like import (
             BaseObjectLike,
         )
-        from ivy.transpiler.translations.data.global_like import (
+        from ivy.transpiler.core.global_like import (
             GlobalObjectLike,
         )
 
diff --git a/ivy_tests/test_transpiler/transformations/globals_transformers/test_globals_transformer.py b/ivy_tests/test_transpiler/transformations/globals_transformers/test_globals_transformer.py
@@ -10,7 +10,7 @@
 from ivy.transpiler.transformations.configurations.base_transformer_config import (
     BaseTransformerConfig,
 )
-from ivy.transpiler.translations.data.object_like import (
+from ivy.transpiler.core.object_like import (
     BaseObjectLike,
 )
 from ivy.transpiler.configurations_container import ConfigurationsContainer
diff --git a/ivy_tests/test_transpiler/transformations/inplace_update_transformers/test_inplace_update_transformer.py b/ivy_tests/test_transpiler/transformations/inplace_update_transformers/test_inplace_update_transformer.py
@@ -10,7 +10,7 @@
 from ivy.transpiler.transformations.transformers.inplace_update_transformer.base_transformer import (
     BaseInplaceUpdateTransformer,
 )
-from ivy.transpiler.translations.data.object_like import (
+from ivy.transpiler.core.object_like import (
     BaseObjectLike,
 )
 from ivy.transpiler.configurations_container import ConfigurationsContainer
diff --git a/ivy_tests/test_transpiler/transformations/methods_transformers/test_frontend_torch_method_transformer.py b/ivy_tests/test_transpiler/transformations/methods_transformers/test_frontend_torch_method_transformer.py
@@ -2,7 +2,7 @@
 import gast
 import torch
 from ivy.transpiler.transformations.transformer import Transformer
-from ivy.transpiler.translations.data.object_like import (
+from ivy.transpiler.core.object_like import (
     BaseObjectLike,
 )
 from ivy.transpiler.configurations_container import ConfigurationsContainer
diff --git a/ivy_tests/test_transpiler/transformations/methods_transformers/test_ivy_method_transformer.py b/ivy_tests/test_transpiler/transformations/methods_transformers/test_ivy_method_transformer.py
@@ -3,7 +3,7 @@
 import ivy
 from ivy.utils.backend import current_backend
 from ivy.transpiler.transformations.transformer import Transformer
-from ivy.transpiler.translations.data.object_like import (
+from ivy.transpiler.core.object_like import (
     BaseObjectLike,
 )
 from ivy.transpiler.configurations_container import ConfigurationsContainer
diff --git a/ivy_tests/test_transpiler/transformations/name_canonicalize_transformers/test_canonicalize_transformer.py b/ivy_tests/test_transpiler/transformations/name_canonicalize_transformers/test_canonicalize_transformer.py
@@ -10,7 +10,7 @@
     BaseTransformerConfig,
 )
 from ivy.transpiler.transformations.transformer import Transformer
-from ivy.transpiler.translations.data.object_like import (
+from ivy.transpiler.core.object_like import (
     BaseObjectLike,
 )
 from ivy.transpiler.configurations_container import ConfigurationsContainer
diff --git a/ivy_tests/test_transpiler/transformations/native_layers_transformers/test_native_layers_transformer.py b/ivy_tests/test_transpiler/transformations/native_layers_transformers/test_native_layers_transformer.py
diff --git a/ivy_tests/test_transpiler/transformations/postprocessing_transformers/test_frontend_torch_postprocessing_transformer.py b/ivy_tests/test_transpiler/transformations/postprocessing_transformers/test_frontend_torch_postprocessing_transformer.py
diff --git a/ivy_tests/test_transpiler/transformations/postprocessing_transformers/test_ivy_to_jax_postprocessing_transformer.py b/ivy_tests/test_transpiler/transformations/postprocessing_transformers/test_ivy_to_jax_postprocessing_transformer.py
diff --git a/ivy_tests/test_transpiler/transformations/postprocessing_transformers/test_ivy_to_tf_postprocessing_transformer.py b/ivy_tests/test_transpiler/transformations/postprocessing_transformers/test_ivy_to_tf_postprocessing_transformer.py
diff --git a/ivy_tests/test_transpiler/transformations/preprocessing_transformers/test_ivy_preprocessing_transformer.py b/ivy_tests/test_transpiler/transformations/preprocessing_transformers/test_ivy_preprocessing_transformer.py
diff --git a/ivy_tests/test_transpiler/transformations/test_transformations.py b/ivy_tests/test_transpiler/transformations/test_transformations.py

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`from ..transformations.transformers.base_transformer import (`
`16`	`16`	`BaseTransformer,`
`17`	`17`	`)`
`18`		`-from ..translations.data.object_like import (`
	`18`	`+from ..core.object_like import (`
`19`	`19`	`BaseObjectLike,`
`20`	`20`	`)`
`21`	`21`	`from ..transformations.transformers.rename_transformer import (`
`@@ -29,10 +29,10 @@`
`29`	`29`	`from ..transformations.transformers.globals_transformer.base_transformer import (`
`30`	`30`	`GlobalObj,`
`31`	`31`	`)`
`32`		`- from ..translations.data.object_like import (`
	`32`	`+ from ..core.object_like import (`
`33`	`33`	`TypeObjectLike,`
`34`	`34`	`)`
`35`		`- from ..translations.data.object_like import (`
	`35`	`+ from ..core.object_like import (`
`36`	`36`	`FuncObjectLike,`
`37`	`37`	`)`
`38`	`38`	`from ..utils.ast_utils import ImportObj, FromImportObj`
Original file line number	Diff line number	Diff line change
`@@ -9,12 +9,12 @@`
`9`	`9`	`BaseTransformer,`
`10`	`10`	`)`
`11`	`11`	`from ...transformer import Transformer`
`12`		`-from ....translations.data.global_like import (`
	`12`	`+from ....core.global_like import (`
`13`	`13`	`GlobalObjectLike,`
`14`	`14`	`Position,`
`15`	`15`	`StackObjectLike,`
`16`	`16`	`)`
`17`		`-from ....translations.data.object_like import BaseObjectLike`
	`17`	`+from ....core.object_like import BaseObjectLike`
`18`	`18`	`from ....ast.analysis import get_function_vars, get_module_globals`
`19`	`19`	`from ....ast.visitors import get_global_assignment`
`20`	`20`	`from ....ast.globals import (`
`@@ -45,7 +45,7 @@`
`45`	`45`	`)`
`46`	`46`
`47`	`47`	`if TYPE_CHECKING:`
`48`		`- from ....translations.data.object_like import (`
	`48`	`+ from ....core.object_like import (`
`49`	`49`	`TypeObjectLike,`
`50`	`50`	`FuncObjectLike,`
`51`	`51`	`)`
Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ def _recursively_translate(self, obj_name: str, obj_to_translate, node=None):`
`199`	`199`	`from_global, parent = self.preprocess_origin_info(obj_to_translate, new_name)`
`200`	`200`
`201`	`201`	`# 3 Recursively transform the function`
`202`		`- from ivy.transpiler.translations.data.object_like import (`
	`202`	`+ from ivy.transpiler.core.object_like import (`
`203`	`203`	`BaseObjectLike,`
`204`	`204`	`)`
`205`	`205`
`@@ -401,7 +401,7 @@ def visit_ClassDef(self, node):`
`401`	`401`	`from_global, parent = self.preprocess_origin_info(base, base_new_name)`
`402`	`402`
`403`	`403`	`# 3 Recursively transform the function`
`404`		`- from ivy.transpiler.translations.data.object_like import (`
	`404`	`+ from ivy.transpiler.core.object_like import (`
`405`	`405`	`BaseObjectLike,`
`406`	`406`	`)`
`407`	`407`