Skip to content

Commit ab8132f

Browse files
author
Andreas Friedrich
committed
fixed renaming of metadata endpoint, added better method naming
1 parent 3913199 commit ab8132f

File tree

5 files changed

+24
-24
lines changed

5 files changed

+24
-24
lines changed

src/Client.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
use Ixopay\Client\CustomerProfile\PaymentInstrument;
99
use Ixopay\Client\CustomerProfile\UpdateProfileResponse;
1010
use Ixopay\Client\Dispute\DisputeAcceptData;
11-
use Ixopay\Client\Dispute\DisputeMetaDataData;
11+
use Ixopay\Client\Dispute\DisputeMetadataData;
1212
use Ixopay\Client\Dispute\DisputeSubmitEvidenceData;
1313
use Ixopay\Client\Dispute\DisputeUploadEvidenceData;
1414
use Ixopay\Client\Exception\GeneralErrorException;
@@ -107,7 +107,7 @@ class Client
107107
const OPTIONS_REQUEST = 'api/v3/options/[API_KEY]/{optionsName}';
108108

109109
const DISPUTE_ACCEPT = 'api/v3/dispute/[API_KEY]/accept/{uuid}';
110-
const DISPUTE_META_DATA = 'api/v3/dispute/[API_KEY]/meta-data/{uuid}';
110+
const DISPUTE_METADATA = 'api/v3/dispute/[API_KEY]/metadata/{uuid}';
111111
const DISPUTE_UPLOAD_EVIDENCE = 'api/v3/dispute/[API_KEY]/upload-evidence/{uuid}';
112112
const DISPUTE_SUBMIT_EVIDENCE = 'api/v3/dispute/[API_KEY]/submit-evidence/{uuid}';
113113

@@ -1231,24 +1231,24 @@ public function acceptDispute(DisputeAcceptData $disputeAcceptData)
12311231
}
12321232

12331233
/**
1234-
* @param DisputeMetaDataData $disputeMetaDataData
1234+
* @param DisputeMetadataData $disputeMetadataData
12351235
* @return Dispute\DisputeResult
12361236
* @throws ClientException
12371237
* @throws GeneralErrorException
12381238
* @throws Http\Exception\ClientException
12391239
* @throws RateLimitException
12401240
* @throws TimeoutException
12411241
*/
1242-
public function metaData(DisputeMetaDataData $disputeMetaDataData)
1242+
public function fetchDisputeMetadata(DisputeMetadataData $disputeMetadataData)
12431243
{
12441244
$url = $this->parseDisputeUrl(
1245-
$disputeMetaDataData->getUuid(),
1246-
self::DISPUTE_META_DATA
1245+
$disputeMetadataData->getUuid(),
1246+
self::DISPUTE_METADATA
12471247
);
12481248

12491249
$data = [];
12501250

1251-
if ($extraData = $disputeMetaDataData->getExtraData()) {
1251+
if ($extraData = $disputeMetadataData->getExtraData()) {
12521252
$data['extraData'] = $this->getGenerator()->stringifyExtraData($extraData);
12531253
}
12541254

@@ -1266,7 +1266,7 @@ public function metaData(DisputeMetaDataData $disputeMetaDataData)
12661266
* @throws RateLimitException
12671267
* @throws TimeoutException
12681268
*/
1269-
public function uploadEvidence(DisputeUploadEvidenceData $disputeUploadEvidenceData)
1269+
public function uploadDisputeEvidence(DisputeUploadEvidenceData $disputeUploadEvidenceData)
12701270
{
12711271
$url = $this->parseDisputeUrl(
12721272
$disputeUploadEvidenceData->getUuid(),
@@ -1303,7 +1303,7 @@ public function uploadEvidence(DisputeUploadEvidenceData $disputeUploadEvidenceD
13031303
* @throws RateLimitException
13041304
* @throws TimeoutException
13051305
*/
1306-
public function submitEvidence(DisputeSubmitEvidenceData $disputeSubmitEvidenceData)
1306+
public function submitDisputeEvidence(DisputeSubmitEvidenceData $disputeSubmitEvidenceData)
13071307
{
13081308
$url = $this->parseDisputeUrl(
13091309
$disputeSubmitEvidenceData->getUuid(),

src/Dispute/DisputeMetaDataData.php

Lines changed: 0 additions & 8 deletions
This file was deleted.
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?php
2+
3+
namespace Ixopay\Client\Dispute;
4+
5+
class DisputeMetadataData extends AbstractDisputeData
6+
{
7+
8+
}

src/Dispute/DisputeResult.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class DisputeResult
1515
/**
1616
* @var array
1717
*/
18-
private $metaData = [];
18+
private $metadata = [];
1919
/**
2020
* @var Error[]
2121
*/
@@ -61,18 +61,18 @@ public function getExtraData()
6161
* @param $metaData
6262
* @return $this
6363
*/
64-
public function setMetaData($metaData)
64+
public function setMetadata($metadata)
6565
{
66-
$this->metaData = $metaData;
66+
$this->metadata = $metadata;
6767
return $this;
6868
}
6969

7070
/**
7171
* @return array
7272
*/
73-
public function getMetaData()
73+
public function getMetadata()
7474
{
75-
return $this->metaData;
75+
return $this->metadata;
7676
}
7777

7878
/**

src/Json/JsonParser.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,8 +320,8 @@ public function parseDisputeResult($jsonString)
320320
$result->setSuccess(true);
321321
$result->setExtraData($this->arrGet($json, 'extraData'));
322322

323-
if ($this->arrGet($json, 'metaData')) {
324-
$result->setMetaData($this->arrGet($json, 'metaData'));
323+
if ($this->arrGet($json, 'metadata')) {
324+
$result->setMetadata($this->arrGet($json, 'metadata'));
325325
}
326326

327327
return $result;

0 commit comments

Comments
 (0)