Skip to content

Commit 1a0870b

Browse files
committed
allow tests to run w/o sidekiq-pro
install_if does all of the bundling work even if the condition is false. That means it fetches the packages list from gems.contribsys.com before it even checks the condition. If BUNDLE_GEMS__CONTRIBSYS__COM isn't set it that fetch fails with an auth error.
1 parent 11aefdf commit 1a0870b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Appraisals

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ appraise "sidekiq-7.0.x" do
66

77
# Sidekiq Pro license must be set in global bundler config
88
# or in BUNDLE_GEMS__CONTRIBSYS__COM env variable
9-
install_if "-> { Bundler.settings['gems.contribsys.com']&.include?(':') }" do
9+
if Bundler.settings["gems.contribsys.com"]&.include?(":")
1010
source "https://gems.contribsys.com/" do
1111
gem "sidekiq-pro", "~> 7.0.0"
1212
end
@@ -20,7 +20,7 @@ appraise "sidekiq-7.1.x" do
2020

2121
# Sidekiq Pro license must be set in global bundler config
2222
# or in BUNDLE_GEMS__CONTRIBSYS__COM env variable
23-
install_if "-> { Bundler.settings['gems.contribsys.com']&.include?(':') }" do
23+
if Bundler.settings["gems.contribsys.com"]&.include?(":")
2424
source "https://gems.contribsys.com/" do
2525
gem "sidekiq-pro", "~> 7.1.0"
2626
end
@@ -34,7 +34,7 @@ appraise "sidekiq-7.2.x" do
3434

3535
# Sidekiq Pro license must be set in global bundler config
3636
# or in BUNDLE_GEMS__CONTRIBSYS__COM env variable
37-
install_if "-> { Bundler.settings['gems.contribsys.com']&.include?(':') }" do
37+
if Bundler.settings["gems.contribsys.com"]&.include?(":")
3838
source "https://gems.contribsys.com/" do
3939
gem "sidekiq-pro", "~> 7.2.0"
4040
end

0 commit comments

Comments
 (0)