fix explicit imports test, remove macos13 test

Author: j-fu

.github/workflows/ci.yml

@@ -19,7 +19,6 @@ jobs:
         os:
           - ubuntu-latest
           - windows-latest
-          - macOS-13 # intel
           - macOS-14 # arm
         arch:
           - x64
@@ -29,8 +28,6 @@ jobs:
             arch: aarch64
           - os: windows-latest
             arch: aarch64
-          - os: macOS-13 
-            arch: aarch64
           - os: macOS-14
             arch: x64
     steps:

src/RotatingElectrodes/rrde_cv.jl

@@ -21,7 +21,7 @@ function CVContext(
         reaction,
         disktype = "E6R1";
         set_voltage = () -> null,
-        bulk_reaction = VoronoiFVM.nofunc,
+        bulk_reaction = nothing,
         nref = 0,
         num_species = 1,
         num_disk_species = 0,
@@ -63,7 +63,7 @@ function CVContext(
             flux = rrde_flux,
             breaction = breaction
         )
-        cvcontext.rdcell = VoronoiFVM.DenseSystem(cvcontext.grid, physics)
+        cvcontext.rdcell = VoronoiFVM.System(cvcontext.grid, physics, unknown_storage = :dense)
     else
         physics = VoronoiFVM.Physics(
             num_species = num_species + num_disk_species,
@@ -73,7 +73,7 @@ function CVContext(
             bstorage = bstorage,
             breaction = breaction
         )
-        cvcontext.rdcell = VoronoiFVM.SparseSystem(cvcontext.grid, physics)
+        cvcontext.rdcell = VoronoiFVM.System(cvcontext.grid, physics, unknown_storage = :sparse)
     end
 
     for ispec in 1:num_species

src/electrolyte.jl

@@ -254,10 +254,6 @@ function Base.show(io::IOContext{Base.IOBuffer}, this::ElectrolyteData)
     return showstruct(io, this)
 end
 
-function Base.show(io::IOContext{Base.DevNull}, this::ElectrolyteData)
-    @info "show3"
-    return showstruct(io, this)
-end
 
 """
     update_derived!(electrolyte::ElectrolyteData)

test/alltests.jl

@@ -134,10 +134,28 @@ end
 
 @testset "ExplicitImports" begin
     @test ExplicitImports.check_no_implicit_imports(LiquidElectrolytes, skip = (Base, Core, Markdown)) === nothing
+    @test ExplicitImports.check_all_explicit_imports_via_owners(LiquidElectrolytes) === nothing
     @test ExplicitImports.check_all_explicit_imports_are_public(LiquidElectrolytes) === nothing
     @test ExplicitImports.check_no_stale_explicit_imports(LiquidElectrolytes, ignore = (:README,)) === nothing
+    @test ExplicitImports.check_all_qualified_accesses_via_owners(LiquidElectrolytes) === nothing
+    @test ExplicitImports.check_all_qualified_accesses_are_public(
+        LiquidElectrolytes,
+        ignore = (
+            :chargedensity!,
+            :extended_unknowns,
+            :flowplot,
+            :flowsolver,
+            :fvm_velocities,
+            :node_pressure,
+            :node_velocity,
+            :velocity_unknown,
+            :voltage!,
+        )
+    ) === nothing
+    @test ExplicitImports.check_no_self_qualified_accesses(LiquidElectrolytes) === nothing
 end
 
+
 @testset "Aqua" begin
     Aqua.test_all(LiquidElectrolytes)
 end