Implements Backward Digit Span task #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: new file: modules/core_wm_modules/backward_digit_span.xml new file: src/main/java/jms/cogtasks/executables/BackwardDigitSpan.java modified: src/main/java/jms/cogtasks/executables/WordDigitSpan.java new file: src/main/resources/jms/cogtasks/instructions/BackwardDigitSpan/BackwardDigitSpanInstructions.html
jcbgamboa
changed the title
Author
|
Hi... I renamed the .xml into something that follows the pattern of the other ones. I also removed the second overridden function, that is not necessary, and made the variables that I used (I guess this should make the code a little cleaner. Feel free to tell me if I can make the code better in any way. I am using this Backward Digit span in an experiment in the next weeks, so I'll be able to tell if there are any bugs that I couldn't notice) |
Owner
|
This sounds good, I'll have a look over it when I get a chance and see if I can spot anything to improve before adding it. Let me know if you have any other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, what I do is:
BackwardDigitSpanclass that extendsWordDigitSpanWordDigitSpanpublic (I could have made them protected, but I didn't care much about modularity)backward_digit_span.xmlfile that is almost identical todefault_digit_span.xml(but refers toBackwardDigitSpaninstead).I know this could have been made much more cleanly and nicely. I don't know how much you care about the cleanliness now (I have to say I am doing this in a rush, but I can take my time in the future and clean if you would like me to =) ).