Use module-level loggers#127
Open
lkraider wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use module-level loggers so that implementers can configure the logging in more granular ways.
The logging module when used directly defaults to the
rootlogger, which while easy to use, does not allow for much control for printing/silencing different modules logging output when on larger projects.Using the standard of instantiating a logger using the module name still keeps logging usage simple, while adding better control, and also helps to show where specific messages are being generated from.
Also the
log_levelparameter is removed from the app initialization, since this is automatically provided by the logging module (users can configure the root module or any named module anywhere before starting the app). A good place for that would be in a settings part of the client app.