EFFECT_DEACTIVATE runs on a disabled Button

[codewalkerdan]

When writing a custom effect for buttons. I noticed that when a button is disabled if you hover and leave the disabled button the EFFECT_DEACTIVATE effect runs regardless. This is more evident using custom styles and effects.

Checking on the Button source code I noticed that the the check if the button is disabled is commented

    @Override
    public void mouseExited( MouseMotionEvent event, Spatial target, Spatial capture ) {
        //if( !isEnabled() )
        //    return;
        if( !isHighlightOn() ) {
            // If the highlight is on then we need to run through
            // the events regardless of enabled state... and if it's 
            // not on then there is no reason to run events. 
        }
        showHighlight(false);
        commandMap.runCommands(ButtonAction.HighlightOff);
        runEffect(EFFECT_DEACTIVATE);
    }

My workaround was to modify my custom disable effect that will check if the button is enabled to execute.

[pspeed42]

I wonder if that is block is supposed to have a return in it.

Whatever the case, you need to run the deactivate if the activate was run... even if the button is now disabled. Otherwise, if activation moves the button then it will just keep sliding over and over every time a activate, disable, deactivate, enable, activate sequence happens.

But probably also, disabling should also probably reset the states (deactivating if active, etc.) and then this code could go back to returning if disabled. But I have to believe the if block probably is supposed to have a return in it.